Package review request (ruby 1.9 attempt too)

[Bohuslav Kabrda]

Hi Michael,
I'd recommend waiting until we get the new guidelines approved by FPC. Anyway, your spec looks pretty good, the only thing that comes to my mind right now is that you don't need to define all the macros, they are defined in macros.rubygems in rubygems-devel package. Because you BR: rubygems-devel, there is no need to BR: ruby(rubygems), as the -devel package will draw them in.
When we get the guidelines approved, I'll be happy to do a complete review for you.

Regards,
Bohuslav.


----- Original Message -----
> I'm working on building out Puppet on Ruby 1.9 for my day job at
> Puppet Labs.  I also recently took over ruby-shadow since it was
> orphaned.  Upstream has moved to github and they now only distribute
> as a gem.  So, the package will be renamed to rubygem-ruby-shadow.
> 
> I *think* I've follwed the new proposed ruby 1.9 guidelines, but I am
> sure I've missed a couple things.  I'm also curious if there is a way
> I could use the same spec for packages still on Ruby 1.8 (Fedora < 17
> and EL)
> 
> Anyway, I'd appreciate Feedback. If it's too early to be attempting
> Ruby 1.9 reviews, that's fine too. :)
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=782560
> 
> 
> stahnma
> _______________________________________________
> ruby-sig mailing list
> ruby-sig at lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/ruby-sig