any hope for logstash?

[Vít Ondruch]

Hi Carl,

I am going to comment only on elasticsearch at this moment, but I 
believe that this comments applies also for other packages (although I 
did not checked them).

* Please focus on Fedora
There is no JRuby on EPEL/RHEL, so any tag trying to make some 
adjustments is distracting. This packages will be peculiar even without 
them. Please remove them.

* Source URL:
You can get the tarball using 
https://github.com/elasticsearch/elasticsearch/archive/v0.20.5/elasticsearch-0.20.5.tar.gz, 
so in your case, it should look like:
  https://github.com/%{name}/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz

* You should always expand the archive in %prep section, using %setup macro

* You should be using %global instead of %define

* You should not install anything into /usr/local

* You should be following Java packaging guidelines for this package, 
especially the maven section [1]. Since I am not expert on Java, I would 
suggest to seek java-sig for help with this particular package.


Vít


[1] https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven



Dne 17.4.2013 22:15, Carl Byington napsal(a):
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> There is a new version available at either
>
> http://www.five-ten-sg.com/util/logstash.fedora.tar.gz
>      or
> hg clone http://hg.five-ten-sg.com/logstash
>
> I found and patched the problem with logstash finding the elasticsearch
> jar files. That path should be specified via a command line switch. This
> version seems to run properly, but the following issues still need work:
>
> 1) the elasticsearch build (using maven) downloads prebuilt .jar files
> and bundles them.
>
> 2) the logstash build still downloads prebuilt gems and bundles them.
>
>
> Is there a document to read regarding proper fedora packaging of jruby
> gems?
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.14 (GNU/Linux)
>
> iEYEARECAAYFAlFvAtQACgkQL6j7milTFsFqrACcDO2W5TrDv+HVRT5LuzhDkCuS
> A8EAniPTSjXC5Oa4KM63b6qoY/93hPS8
> =I5dr
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> ruby-sig mailing list
> ruby-sig at lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/ruby-sig