Review swap

[Achilleas Pipinellis]

On 01/21/14 02:54, Mo Morsi wrote:
> On 01/20/2014 06:27 PM, Achilleas Pipinellis wrote:
>> Hey, can someone review awesome_spawn[0]?
>> I'd like to bring polisher[1] in Fedora and awesome_spawn is the only
>> missing dependency.
>>
>> Hopefully, once polisher hits the repos, it'll be easier to use it and
>> report any bug/feature requests :)
>>
>>
>> [0] https://bugzilla.redhat.com/show_bug.cgi?id=1055789
>> [1] https://github.com/ManageIQ/polisher
>>
> 
> I can take a look at the awesome_spawn submission tomorrow.
> 

Thanks!

> Polisher can also be installed via gem. You will need to yum install the
> curb dependencies first (eg libcurl-devel and ruby-devel) but once you
> have those you can just:
> 
> gem install polisher
> 

Yeap, I know that. :)

> Mileage may vary though as there is alot of optional stuff, eg querying
> certain targets depends on various commands such as fedpkg and git being
> available. If they aren't you most likely will get errs (just added an
> issue to change this to gracefully print err msgs and exit).
> 

That's true, but a big portion of this gem's functionality is supposed
to target packagers, right? So I guess one who installs it, should know
how it works. Nevertheless it's good to exist graceful exits :)

> Advantage that the rpm install has over the gem is that we can add deps
> to the packages provided the cmds (or to the cmds themselves), though
> might want to split it up into optional components at some point (if it
> gets bigger).
> 
> Appreciate the submissions,
>   -Mo

Thanks for your work!


-- 
FAS : axilleas
GPG : 0xABF99BE5
Blog: http://axilleas.me