rpms/jhead/FC-3 jhead-compiler-warnings.patch,1.1,1.2

[Adrian Reber]

On Sun, Jul 10, 2005 at 07:45:26AM +0200, Ralf Corsepius wrote:
> On Fri, 2005-07-08 at 18:03 -0400, Adrian Reber wrote:
> > Author: adrian
> > 
> > Update of /cvs/extras/rpms/jhead/FC-3
> > In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv12182
> > 
> > Modified Files:
> > 	jhead-compiler-warnings.patch 
> > Log Message:
> > don't reverse the other patch
> > 
> > 
> > jhead-compiler-warnings.patch:
> > 
> > Index: jhead-compiler-warnings.patch
> 
> > -+++ jhead-2.4.new/makefile	2005-06-10 15:39:56.000000000 +0200
> > -@@ -9,7 +9,7 @@
> > - objs = $(OBJ)/jhead.o $(OBJ)/jpgfile.o $(OBJ)/exif.o $(OBJ)/gpsinfo.o $(OBJ)/makernote.o 
> > - 
> > - $(OBJ)/%.o:$(SRC)/%.c
> > --	${CC} ${CFLAGS} -Wall -c $< -o $@
> > -+	${CC} -O3 -Wall -c $< -o $@
> You should be using the contents of RPM_OPT_FLAGS.
> 
> Hard-coding -O3 should be non-acceptable unless there is a very well
> thought out reason to make an exception.
> 
> I vote for putting this package on HOLD before this issue can be
> clarified.

This patch is removing the hard-coding -O3 again. The tarball does -O3
and I had a patch which removed it. Then a second patch reversed it to
-O3 again by accident and this patch reverses it back to ${CFLAGS}.

		Adrian