rpms/gstreamer-plugins-base/OLPC-2 gstplaybin-stream-info-value-array-fix.patch, 1.1, 1.2

Daniel Williams (dcbw) fedora-extras-commits at redhat.com
Sun Jul 22 04:54:16 UTC 2007


Author: dcbw

Update of /cvs/extras/rpms/gstreamer-plugins-base/OLPC-2
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv28690

Modified Files:
	gstplaybin-stream-info-value-array-fix.patch 
Log Message:
Fix patch, don't leak an array

gstplaybin-stream-info-value-array-fix.patch:

Index: gstplaybin-stream-info-value-array-fix.patch
===================================================================
RCS file: /cvs/extras/rpms/gstreamer-plugins-base/OLPC-2/gstplaybin-stream-info-value-array-fix.patch,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- gstplaybin-stream-info-value-array-fix.patch	22 Jul 2007 04:42:05 -0000	1.1
+++ gstplaybin-stream-info-value-array-fix.patch	22 Jul 2007 04:53:39 -0000	1.2
@@ -1,35 +1,11 @@
---- gst-plugins-base-0.10.12/gst/playback/gstplaybasebin.c.debug	2007-03-05 06:13:29.000000000 -0500
-+++ gst-plugins-base-0.10.12/gst/playback/gstplaybasebin.c	2007-07-22 00:00:08.000000000 -0400
-@@ -21,6 +21,8 @@
- #include "config.h"
- #endif
- 
-+#include <stdio.h>
-+
- #include <gst/gst-i18n-plugin.h>
- #include <string.h>
- #include "gstplaybasebin.h"
-@@ -2504,6 +2506,7 @@ gst_play_base_bin_get_property (GObject 
-       GValueArray *copy;
- 
-       copy = gst_play_base_bin_get_streaminfo_value_array (play_base_bin);
-+fprintf (stderr, "%s %s():%d copy is %p\n", __FILE__, __func__, __LINE__, copy);
-       g_value_take_boxed (value, copy);
-       break;
-     }
-@@ -2611,12 +2614,14 @@ static GValueArray *
- gst_play_base_bin_get_streaminfo_value_array (GstPlayBaseBin * play_base_bin)
- {
-   GstPlayBaseGroup *group;
--  GValueArray *array = NULL;
-+  GValueArray *array = g_value_array_new (0);
- 
-   GROUP_LOCK (play_base_bin);
+--- gst-plugins-base-0.10.12/gst/playback/gstplaybasebin.c.stream-info-value-array-fix	2007-03-05 06:13:29.000000000 -0500
++++ gst-plugins-base-0.10.12/gst/playback/gstplaybasebin.c	2007-07-22 00:45:08.000000000 -0400
+@@ -2617,6 +2617,8 @@ gst_play_base_bin_get_streaminfo_value_a
    group = get_active_group (play_base_bin);
-+fprintf (stderr, "%s %s():%d group is %p\n", __FILE__, __func__, __LINE__, group);
    if (group) {
      array = g_value_array_copy (group->streaminfo_value_array);
-+fprintf (stderr, "%s %s():%d array is %p\n", __FILE__, __func__, __LINE__, array);
++  } else {
++    array = g_value_array_new (0);
    }
    GROUP_UNLOCK (play_base_bin);
  




More information about the scm-commits mailing list