rpms/libbonobo/devel list-leak.patch, NONE, 1.1 libbonobo.spec, 1.61, 1.62

[Matthias Clasen (mclasen)]

Author: mclasen

Update of /cvs/extras/rpms/libbonobo/devel
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv26324

Modified Files:
	libbonobo.spec 
Added Files:
	list-leak.patch 
Log Message:
plug a memory leak


list-leak.patch:

--- NEW FILE list-leak.patch ---
diff -up libbonobo-2.19.6/activation-server/object-directory-load.c.list-leak libbonobo-2.19.6/activation-server/object-directory-load.c
--- libbonobo-2.19.6/activation-server/object-directory-load.c.list-leak	2007-09-12 18:41:20.000000000 -0400
+++ libbonobo-2.19.6/activation-server/object-directory-load.c	2007-09-12 21:33:20.000000000 -0400
@@ -483,7 +483,8 @@ od_end_element (GMarkupParseContext *con
                         info->cur_prop->v._u.value_stringv._buffer =
                                 CORBA_sequence_CORBA_string_allocbuf (len);
                         
-                        for (i = 0, p = g_list_reverse (info->cur_items); p; p = p->next, i++)
+			info->cur_items = g_list_reverse (info->cur_items);
+                        for (i = 0, p = info->cur_items; p; p = p->next, i++)
                                 info->cur_prop->v._u.
                                         value_stringv._buffer[i] = p->data;
                         g_list_free (info->cur_items);
@@ -509,7 +510,8 @@ od_end_element (GMarkupParseContext *con
                         info->cur_server->props._buffer =
                                 CORBA_sequence_Bonobo_ActivationProperty_allocbuf (len);
 
-                        for (i = 0, p = g_list_reverse (info->cur_props); p; p = p->next, i++) {
+			info->cur_props = g_list_reverse (info->cur_props);
+                        for (i = 0, p = info->cur_props; p; p = p->next, i++) {
                                 Bonobo_ActivationProperty_copy (&info->cur_server->props._buffer[i],
                                                                 (Bonobo_ActivationProperty *) p->data);
                                 CORBA_free (p->data);


Index: libbonobo.spec
===================================================================
RCS file: /cvs/extras/rpms/libbonobo/devel/libbonobo.spec,v
retrieving revision 1.61
retrieving revision 1.62
diff -u -r1.61 -r1.62
--- libbonobo.spec	29 Aug 2007 04:22:53 -0000	1.61
+++ libbonobo.spec	13 Sep 2007 01:41:45 -0000	1.62
@@ -6,7 +6,7 @@
 Summary: Bonobo component system
 Name: libbonobo
 Version: 2.19.6
-Release: 4%{?dist}
+Release: 5%{?dist}
 URL: http://ftp.gnome.org
 Source0: http://download.gnome.org/sources/libbonobo/2.19/%{name}-%{version}.tar.bz2
 License: GPLv2+ and LGPLv2+
@@ -26,6 +26,8 @@
 Provides: bonobo-activation = %{version}-%{release}
 
 Patch0: libbonobo-2.13.1-multishlib.patch
+# http://bugzilla.gnome.org/show_bug.cgi?id=476398
+Patch1: list-leak.patch
 
 %description
 Bonobo is a component system based on CORBA, used by the GNOME desktop.
@@ -58,6 +60,8 @@
 %patch0 -p1 -b .multishlib
 %endif
 
+%patch1 -p1 -b .list-leak
+
 %build
 intltoolize -f
 aclocal
@@ -122,6 +126,9 @@
 %{_datadir}/gtk-doc/html/bonobo-activation
 
 %changelog
+* Wed Sep 12 2007 Matthias Clasen <mclasen at redhat.com> - 2.19.6-5
+- Plug a memory leak in bonobo-activation-server
+
 * Tue Aug 28 2007 Jesse Keating <jkeating at redhat.com> - 2.19.6-4
 - Require popt-devel in -devel.
 - And BuildRequire popt-devel.