rpms/xfdesktop/F-8 xfdesktop-4.4.2-memleak.patch, NONE, 1.1 xfdesktop.spec, 1.20, 1.21

[Kevin Fenzi]

Author: kevin

Update of /cvs/extras/rpms/xfdesktop/F-8
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv5534

Modified Files:
	xfdesktop.spec 
Added Files:
	xfdesktop-4.4.2-memleak.patch 
Log Message:
Add partial memory leak patch (partially fixes #428662)


xfdesktop-4.4.2-memleak.patch:

--- NEW FILE xfdesktop-4.4.2-memleak.patch ---
diff -Nur xfdesktop-4.4.2.orig/modules/menu/desktop-menu-dentry.c xfdesktop-4.4.2/modules/menu/desktop-menu-dentry.c
--- xfdesktop-4.4.2.orig/modules/menu/desktop-menu-dentry.c	2007-11-17 12:31:43.000000000 -0700
+++ xfdesktop-4.4.2/modules/menu/desktop-menu-dentry.c	2008-08-11 21:49:14.000000000 -0600
@@ -173,6 +173,7 @@
         if(cmpname && g_ascii_strcasecmp(name, cmpname) < 0)
             break;
     }
+    g_list_free(items);
     
     gtk_menu_shell_insert(menu_shell, mi, i);
     
diff -Nur xfdesktop-4.4.2.orig/modules/menu/desktop-menuspec.c xfdesktop-4.4.2/modules/menu/desktop-menuspec.c
--- xfdesktop-4.4.2.orig/modules/menu/desktop-menuspec.c	2007-11-17 12:31:43.000000000 -0700
+++ xfdesktop-4.4.2/modules/menu/desktop-menuspec.c	2008-08-11 21:50:14.000000000 -0600
@@ -203,7 +203,7 @@
                 else
                     foundcat = NULL;
                 if(!foundcat) {
-                    g_ptr_array_free(revpath, FALSE);
+                    g_ptr_array_free(revpath, TRUE);
                     revpath = NULL;
                     break;
                 }
@@ -220,7 +220,7 @@
                 newpath[totlen] = 0;
                 
                 g_ptr_array_add(mtfpi->paths, newpath);
-                g_ptr_array_free(revpath, FALSE);
+                g_ptr_array_free(revpath, TRUE);
             }
         }
     }


Index: xfdesktop.spec
===================================================================
RCS file: /cvs/extras/rpms/xfdesktop/F-8/xfdesktop.spec,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- xfdesktop.spec	10 Dec 2007 19:41:28 -0000	1.20
+++ xfdesktop.spec	10 Oct 2008 00:15:10 -0000	1.21
@@ -1,7 +1,7 @@
 Summary: Desktop manager for the XFce Desktop Environment
 Name: xfdesktop
 Version: 4.4.2
-Release: 1%{?dist}
+Release: 2%{?dist}
 License: GPLv2+
 URL: http://www.xfce.org/
 Source0: http://www.xfce.org/archive/xfce-4.4.2/src/xfdesktop-4.4.2.tar.bz2
@@ -9,6 +9,9 @@
 # Change default for Fedora
 Patch0: xfdesktop-image-4.3.90.1.patch
 
+# plug memory leak
+Patch1: xfdesktop-4.4.2-memleak.patch
+
 Group: User Interface/Desktops
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
@@ -36,6 +39,7 @@
 %setup -q
 
 %patch0 -p1 -b .fedora
+%patch1 -p1 -b .memleak
 
 %build
 %configure
@@ -81,6 +85,9 @@
 %{_mandir}/man1/*
 
 %changelog
+* Thu Oct 09 2008 Kevin Fenzi <kevin at tummy.com> - 4.4.2-2
+- Add partial memory leak patch (partially fixes #428662)
+
 * Sun Nov 18 2007 Kevin Fenzi <kevin at tummy.com> - 4.4.2-1
 - Update to 4.4.2