rpms/kernel/devel perf,1.3,1.4

roland roland at fedoraproject.org
Mon Aug 17 00:35:45 UTC 2009


Author: roland

Update of /cvs/pkgs/rpms/kernel/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv18274

Modified Files:
	perf 
Log Message:
Like that, but with some proper defensive sh habits and care to the error case.


Index: perf
===================================================================
RCS file: /cvs/pkgs/rpms/kernel/devel/perf,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -p -r1.3 -r1.4
--- perf	16 Aug 2009 22:09:02 -0000	1.3
+++ perf	17 Aug 2009 00:35:44 -0000	1.4
@@ -1,9 +1,12 @@
 #!/bin/sh
 
-PERF="/usr/libexec/perf.$(uname -r)"
+# In pathological situations, this will print some error about uname.
+kverrel="`uname -r`" || exit
 
-if [ -x $PERF ]; then
-	exec $PERF;
-else
-	echo "Sorry, your kernel doesn't support perf.";
-fi
+exec "/usr/libexec/perf.$kverrel"
+rc=$?
+
+# We're still here, so the exec failed.
+echo >&2 "Sorry, your kernel ($kverrel) doesn't support perf."
+
+exit $rc




More information about the scm-commits mailing list