status-report-scripts pyGetReviewByFlags,1.17,1.18

Jason ティビツ tibbs at fedoraproject.org
Thu Feb 12 03:17:08 UTC 2009


Author: tibbs

Update of /cvs/fedora/status-report-scripts
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv23345

Modified Files:
	pyGetReviewByFlags 
Log Message:
Fix error where xmlrpc fails to marshal a set to a list.
Only filter by dependency status for new tickets.
  (It was pointless and took a few extra big bugzilla queries.)



Index: pyGetReviewByFlags
===================================================================
RCS file: /cvs/fedora/status-report-scripts/pyGetReviewByFlags,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- pyGetReviewByFlags	14 Aug 2008 22:49:34 -0000	1.17
+++ pyGetReviewByFlags	12 Feb 2009 03:17:08 -0000	1.18
@@ -130,10 +130,12 @@
         bugdata[bug.bug_id]['depends'] = set(str(bug.dependson).split(', '))-set([''])
         alldeps |= bugdata[bug.bug_id]['depends']
 
-    # Now look up info on everything that blocks any review ticket, so we can check their status
-    for bug in filter(None, bz.getbugssimple(alldeps)):
-        if bug.bug_status == 'CLOSED':
-            closeddeps.add(str(bug.bug_id))
+    # If we're looking at unreviewed tickets, look up info on everything that
+    # blocks them so we can filter out the unreviewable ones.
+    if flag == ' ':
+        for bug in filter(None, bz.getbugssimple(list(alldeps))):
+            if bug.bug_status == 'CLOSED':
+                closeddeps.add(str(bug.bug_id))
 
     def opendep(id): return id not in closeddeps
     for bug in bugs:




More information about the scm-commits mailing list