rpms/cronie/F-10 Inotify-initialization-left-open-file-descriptors-wh.patch, NONE, 1.1 cronie.spec, 1.17, 1.18

[Marcela Mašláňová]

Author: mmaslano

Update of /cvs/pkgs/rpms/cronie/F-10
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv21886

Modified Files:
	cronie.spec 
Added Files:
	Inotify-initialization-left-open-file-descriptors-wh.patch 
Log Message:
* Mon May  4 2009 Marcela Mašláňová <mmaslano at redhat.com> - 1.2-8
- 498419 fix leaking file descriptor which makes SElinux unhappy


Inotify-initialization-left-open-file-descriptors-wh.patch:

--- NEW FILE Inotify-initialization-left-open-file-descriptors-wh.patch ---
>From 0c43f4b4b8e39f32e3c6eeaed944f5cd3ee0508f Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Marcela=20Ma=C5=A1l=C3=A1=C5=88ov=C3=A1?= <mmaslano at redhat.com>
Date: Thu, 23 Apr 2009 11:24:33 +0200
Subject: [PATCH] Inotify initialization left open file descriptors which are leaking
 and annoying SElinux.
 This could be once fixed by inotify_init1, but that's supported from
 kernel 2.6.27.

---
 src/cron.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/cron.c b/src/cron.c
index 28aebce..5b0ce2d 100644
--- a/src/cron.c
+++ b/src/cron.c
@@ -241,6 +241,7 @@ main(int argc, char *argv[]) {
 	}
 
 	database.ifd = fd = inotify_init();
+	fcntl(fd, F_SETFD, FD_CLOEXEC);
 	if (fd < 0)
 		log_it("CRON", pid, "INFO", "Inotify init failed", errno);
 	set_cron_watched(fd);
-- 
1.6.2.2



Index: cronie.spec
===================================================================
RCS file: /cvs/pkgs/rpms/cronie/F-10/cronie.spec,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -p -r1.17 -r1.18
--- cronie.spec	23 Dec 2008 09:02:22 -0000	1.17
+++ cronie.spec	4 May 2009 10:03:40 -0000	1.18
@@ -6,7 +6,7 @@
 Summary: Cron daemon for executing programs at set times
 Name: cronie
 Version: 1.2
-Release: 7%{?dist}
+Release: 8%{?dist}
 License: MIT and BSD
 Group: System Environment/Base
 URL: https://fedorahosted.org/cronie
@@ -16,6 +16,7 @@ Patch0:	init.patch
 Patch1: nofollow.patch
 Patch2: cronie-1.2-reload.patch
 Patch3: 0001-Update-manual-for-symlink.patch
+Patch4: Inotify-initialization-left-open-file-descriptors-wh.patch
 Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 Requires: syslog, bash >= 2.0
@@ -54,6 +55,7 @@ SELinux.
 %patch1 -p1
 %patch2 -p1
 %patch3 -p1
+%patch4 -p1
 
 %build
 
@@ -133,6 +135,9 @@ cp -a /var/lock/subsys/crond /var/lock/s
 %config(noreplace) %{_sysconfdir}/cron.deny
 
 %changelog
+* Mon May  4 2009 Marcela Mašláňová <mmaslano at redhat.com> - 1.2-8
+- 498419 fix leaking file descriptor which makes SElinux unhappy
+
 * Tue Dec 23 2008 Marcela Mašláňová <mmaslano at redhat.com> - 1.2-7
 - fix errors in man