rpms/kernel/F-10 net-revert-forcedeth-power-down-phy-when-interface-is.patch, NONE, 1.1 kernel.spec, 1.1362, 1.1363

Chuck Ebbert cebbert at fedoraproject.org
Thu May 14 18:26:59 UTC 2009


Author: cebbert

Update of /cvs/pkgs/rpms/kernel/F-10
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv1007

Modified Files:
	kernel.spec 
Added Files:
	net-revert-forcedeth-power-down-phy-when-interface-is.patch 
Log Message:
net-revert-forcedeth-power-down-phy-when-interface-is.patch:
   Fix forcedeth failures, (F11#484505)

net-revert-forcedeth-power-down-phy-when-interface-is.patch:

--- NEW FILE net-revert-forcedeth-power-down-phy-when-interface-is.patch ---
>From c1043da4aa23c180e36399f7c32cb909f7924c31 Mon Sep 17 00:00:00 2001
From: Kyle McMartin <kyle at ihatethathostname.lab.bos.redhat.com>
Date: Mon, 11 May 2009 12:49:30 -0400
Subject: [PATCH] Revert "forcedeth: power down phy when interface is down"

This reverts commit cb52deba12f27af90a46d2f8667a64888118a888.
---
 drivers/net/forcedeth.c |   12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index df0794e..3798f67 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -1446,9 +1446,9 @@ static int phy_init(struct net_device *dev)
 	/* some phys clear out pause advertisment on reset, set it back */
 	mii_rw(dev, np->phyaddr, MII_ADVERTISE, reg);
 
-	/* restart auto negotiation, power down phy */
+	/* restart auto negotiation */
 	mii_control = mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ);
-	mii_control |= (BMCR_ANRESTART | BMCR_ANENABLE | BMCR_PDOWN);
+	mii_control |= (BMCR_ANRESTART | BMCR_ANENABLE);
 	if (mii_rw(dev, np->phyaddr, MII_BMCR, mii_control)) {
 		return PHY_ERROR;
 	}
@@ -5210,10 +5210,6 @@ static int nv_open(struct net_device *dev)
 
 	dprintk(KERN_DEBUG "nv_open: begin\n");
 
-	/* power up phy */
-	mii_rw(dev, np->phyaddr, MII_BMCR,
-	       mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ) & ~BMCR_PDOWN);
-
 	/* erase previous misconfiguration */
 	if (np->driver_data & DEV_HAS_POWER_CNTRL)
 		nv_mac_reset(dev);
@@ -5407,10 +5403,6 @@ static int nv_close(struct net_device *dev)
 	if (np->wolenabled) {
 		writel(NVREG_PFF_ALWAYS|NVREG_PFF_MYADDR, base + NvRegPacketFilterFlags);
 		nv_start_rx(dev);
-	} else {
-		/* power down phy */
-		mii_rw(dev, np->phyaddr, MII_BMCR,
-		       mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ)|BMCR_PDOWN);
 	}
 
 	/* FIXME: power down nic */
-- 
1.6.2.2



Index: kernel.spec
===================================================================
RCS file: /cvs/pkgs/rpms/kernel/F-10/kernel.spec,v
retrieving revision 1.1362
retrieving revision 1.1363
diff -u -p -r1.1362 -r1.1363
--- kernel.spec	13 May 2009 15:57:48 -0000	1.1362
+++ kernel.spec	14 May 2009 18:26:28 -0000	1.1363
@@ -645,6 +645,8 @@ Patch611: alsa-hda-update-quirks.patch
 Patch612: alsa-pcm-core-avoid-jiffies-check.patch
 Patch613: alsa-hda-hp-tx25xx-quirk.patch
 
+Patch630: net-revert-forcedeth-power-down-phy-when-interface-is.patch
+
 Patch670: linux-2.6-ata-quirk.patch
 
 Patch680: linux-2.6-rt2x00-asus-leds.patch
@@ -1254,6 +1256,7 @@ ApplyPatch alsa-pcm-core-avoid-jiffies-c
 ApplyPatch alsa-hda-hp-tx25xx-quirk.patch
 
 # Networking
+ApplyPatch net-revert-forcedeth-power-down-phy-when-interface-is.patch
 
 # Misc fixes
 # The input layer spews crap no-one cares about.
@@ -1928,6 +1931,10 @@ fi
 %kernel_variant_files -k vmlinux %{with_kdump} kdump
 
 %changelog
+* Thu May 14 2009 Chuck Ebbert <cebbert at redhat.com> 2.6.29.3-63
+- net-revert-forcedeth-power-down-phy-when-interface-is.patch:
+   Fix forcedeth failures, (F11#484505)
+
 * Wed May 13 2009 Chuck Ebbert <cebbert at redhat.com> 2.6.29.3-62
 - Fix sound on HP TX25xx series notebooks (#498060)
 




More information about the scm-commits mailing list