rpms/kernel/F-10 linux-2.6-usb-cdc-acm-remove-low-latency-flag.patch, 1.1, 1.2

Chuck Ebbert cebbert at fedoraproject.org
Thu May 28 21:15:16 UTC 2009


Author: cebbert

Update of /cvs/pkgs/rpms/kernel/F-10
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv3959

Modified Files:
	linux-2.6-usb-cdc-acm-remove-low-latency-flag.patch 
Log Message:
replace with upstream patch

linux-2.6-usb-cdc-acm-remove-low-latency-flag.patch:

Index: linux-2.6-usb-cdc-acm-remove-low-latency-flag.patch
===================================================================
RCS file: /cvs/pkgs/rpms/kernel/F-10/linux-2.6-usb-cdc-acm-remove-low-latency-flag.patch,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -p -r1.1 -r1.2
--- linux-2.6-usb-cdc-acm-remove-low-latency-flag.patch	14 Apr 2009 13:39:50 -0000	1.1
+++ linux-2.6-usb-cdc-acm-remove-low-latency-flag.patch	28 May 2009 21:14:45 -0000	1.2
@@ -1,16 +1,29 @@
-USB: cdc-acm: don't set tty low_latency flag
+From: Alan Cox <alan at lxorguk.ukuu.org.uk>
+Date: Tue, 14 Apr 2009 13:57:36 +0000 (+0100)
+Subject: cdc-acm: Fix long standing abuse of tty->low_latency
+X-Git-Tag: v2.6.30-rc2~13
+X-Git-Url: http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git;a=commitdiff_plain;h=7a9a65ced11ece416b730d6f21040a18e62d78a8
 
-"The hack setting of it for high data rate devices was obsolete when the
-tty buffer changes went in so it can definitely go in those cases."
-  --Alan Cox
+cdc-acm: Fix long standing abuse of tty->low_latency
 
-Signed-off-by: Chuck Ebbert <cebbert at redhat.com>
+ACM sets the low latency flag but calls the flip buffer routines from
+IRQ context which isn't permitted (and as of 2.6.29 causes a warning
+hence this one was caught)
 
-Index: linux-2.6.29.noarch/drivers/usb/class/cdc-acm.c
-===================================================================
---- linux-2.6.29.noarch.orig/drivers/usb/class/cdc-acm.c
-+++ linux-2.6.29.noarch/drivers/usb/class/cdc-acm.c
-@@ -546,10 +546,6 @@ static int acm_tty_open(struct tty_struc
+Fortunatelt ACM doesn't need to set this flag in the first place as it
+only set it to work around problems in ancient (pre tty flip rewrite)
+kernels.
+
+Reported-by: Chuck Ebbert <cebbert at redhat.com>
+Signed-off-by: Alan Cox <alan at lxorguk.ukuu.org.uk>
+Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
+---
+
+diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
+index 869d47c..0a69c09 100644
+--- a/drivers/usb/class/cdc-acm.c
++++ b/drivers/usb/class/cdc-acm.c
+@@ -546,10 +546,6 @@ static int acm_tty_open(struct tty_struct *tty, struct file *filp)
  	tty->driver_data = acm;
  	acm->tty = tty;
  




More information about the scm-commits mailing list