rpms/gerbv/EL-5 gerbv-empty_orientation.patch, NONE, 1.1 gerbv.spec, 1.4, 1.5 import.log, 1.2, 1.3

[Chitlesh GOORAH]

Author: chitlesh

Update of /cvs/pkgs/rpms/gerbv/EL-5
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv19673/EL-5

Modified Files:
	gerbv.spec import.log 
Added Files:
	gerbv-empty_orientation.patch 
Log Message:
no layer orientation crash fix

gerbv-empty_orientation.patch:
 callbacks.c |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

--- NEW FILE gerbv-empty_orientation.patch ---
--- src/callbacks.c	2009-07-10 23:34:26.000000000 +0200
+++ callbacks.c	2009-09-13 15:59:38.561102851 +0200
@@ -1997,6 +1997,14 @@
 callbacks_change_layer_orientation_clicked  (GtkButton *button, gpointer userData){
 	gint index = callbacks_get_selected_row_index();
 
+	if (index < 0) {
+		interface_show_alert_dialog("No layers are currently loaded",
+									"A layer must be loaded before the orientation can be modified.",
+									FALSE,
+									NULL);
+		return;
+	}
+	
 	interface_show_modify_orientation_dialog(&mainProject->file[index]->transform,screen.unit);
 	render_refresh_rendered_image_on_screen ();
 	callbacks_update_layer_tree ();	
@@ -2433,7 +2441,7 @@
 callbacks_delete_objects_clicked (GtkButton *button, gpointer   user_data){
 	if (screen.selectionInfo.type == GERBV_SELECTION_EMPTY) {
 		interface_show_alert_dialog("No object is currently selected",
-		                        NULL,
+		                        "Objects must be selected using the pointer tool before they can be deleted.",
 		                        FALSE,
 		                        NULL);
 		return;


Index: gerbv.spec
===================================================================
RCS file: /cvs/pkgs/rpms/gerbv/EL-5/gerbv.spec,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -p -r1.4 -r1.5
--- gerbv.spec	12 Jul 2009 09:21:23 -0000	1.4
+++ gerbv.spec	13 Sep 2009 15:24:19 -0000	1.5
@@ -1,13 +1,18 @@
+# Fixing the end-of-line encodings is omitted because of
+# https://fedorahosted.org/fedora-electronic-lab/ticket/47
+
 Name:             gerbv
 Version:          2.3.0
-Release:          1%{?dist}
+Release:          2%{?dist}
 Summary:          Gerber file viewer from the gEDA toolkit
 
 Group:            Applications/Engineering
 License:          GPLv2
-URL:              http://gerbv.sourceforge.net/
+URL:              http://gerbv.gpleda.org/index.html
 
 Source:           http://downloads.sourceforge.net/gerbv/%{name}-%{version}.tar.gz
+# Fix bug 2841371 (segfault on edit->orientation with no layer loaded
+Patch0:           gerbv-empty_orientation.patch
 
 BuildRoot:        %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires:    gtk2-devel, libpng-devel, desktop-file-utils, automake, ImageMagick-devel
@@ -44,6 +49,8 @@ you will need to install %{name}-devel.
 %prep
 %setup -q
 
+%patch0 -p0 -b .orientation
+
 %build
 
 # default measurement units set to millimeters
@@ -65,7 +72,7 @@ sed -i -e 's! -shared ! -Wl,--as-needed\
 %{__make} INSTALL="%{__install} -p" install DESTDIR=%{buildroot}
 
 
-desktop-file-install --vendor fedora           \
+desktop-file-install --vendor ""               \
     --remove-category Education                \
     --dir %{buildroot}%{_datadir}/applications \
     --delete-original                          \
@@ -89,17 +96,6 @@ for dir in * ; do
 done
 popd
 
-#Fixing the end-of-line encodings
-set +x
-for f in `find example/ -name \*.* | sort` doc/eagle/eagle2exc.txt ; do
-   echo -n -e "... Fixing the end-of-line encodings of $f  \t"
-   sed -i.bak -e 's|\r||g' $f
-   touch -r $f.bak $f
-   %{__rm} -f $f.bak
-   echo "done"
-done
-set -x
-
 
 %clean
 %{__rm} -rf %{buildroot}
@@ -119,7 +115,7 @@ touch --no-create %{_datadir}/icons/hico
 
 %files
 %defattr(-,root,root,-)
-%doc AUTHORS ChangeLog COPYING NEWS README TODO
+%doc AUTHORS ChangeLog COPYING NEWS README TODO CONTRIBUTORS HACKING
 %doc example/
 %doc doc/example-code
 %doc doc/eagle
@@ -131,7 +127,7 @@ touch --no-create %{_datadir}/icons/hico
 %{_mandir}/man1/gerbv.*
 %{_datadir}/icons/hicolor/??x??/apps/%{name}.png
 %{_datadir}/icons/hicolor/scalable/apps/%{name}.svg
-%{_datadir}/applications/fedora-%{name}.desktop
+%{_datadir}/applications/%{name}.desktop
 %{_libdir}/lib%{name}.so.*
 
 
@@ -144,6 +140,10 @@ touch --no-create %{_datadir}/icons/hico
 
 
 %Changelog
+* Sun Sep 13 2009 Chitlesh Goorah <chitlesh [AT] fedoraproject DOT org> - 2.3.0-2
+- Fixed gerbv-2.3.0-1 png failed to open - FEL ticket #47 
+- Fixed bug 2841371 (segfault on edit->orientation with no layer loaded)
+
 * Sat Jul 11 2009 Chitlesh Goorah <chitlesh [AT] fedoraproject DOT org> - 2.3.0-1
 - new upstream release
 


Index: import.log
===================================================================
RCS file: /cvs/pkgs/rpms/gerbv/EL-5/import.log,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -p -r1.2 -r1.3
--- import.log	12 Jul 2009 09:21:23 -0000	1.2
+++ import.log	13 Sep 2009 15:24:19 -0000	1.3
@@ -1,2 +1,3 @@
 gerbv-2_1_0-2_fc9:EL-5:gerbv-2.1.0-2.fc9.src.rpm:1226668665
 gerbv-2_3_0-1_fc11:EL-5:gerbv-2.3.0-1.fc11.src.rpm:1247390404
+gerbv-2_3_0-2_fc11:EL-5:gerbv-2.3.0-2.fc11.src.rpm:1252855094