[sssd/f12/master] Resolves: CVE-2010-2940

[Stephen Gallagher]

commit ed11d25f774479726491b3c6d6d07933bf8d3559
Author: Stephen Gallagher <sgallagh at redhat.com>
Date:   Tue Aug 24 11:59:21 2010 -0400

    Resolves: CVE-2010-2940

 ...Treat-a-zero-length-password-as-a-failure.patch |   32 ++++++++++++++++++++
 sssd.spec                                          |    9 +++++-
 2 files changed, 40 insertions(+), 1 deletions(-)
---
diff --git a/0001-Treat-a-zero-length-password-as-a-failure.patch b/0001-Treat-a-zero-length-password-as-a-failure.patch
new file mode 100644
index 0000000..24c1570
--- /dev/null
+++ b/0001-Treat-a-zero-length-password-as-a-failure.patch
@@ -0,0 +1,32 @@
+From 8eeb47279a5a4559d9d7f911250d6164ab120897 Mon Sep 17 00:00:00 2001
+From: Stephen Gallagher <sgallagh at redhat.com>
+Date: Wed, 18 Aug 2010 12:57:43 -0400
+Subject: [PATCH 9/9] Treat a zero-length password as a failure
+
+Some LDAP servers allow binding with blank passwords. We should
+not allow a blank password to authenticate the SSSD.
+---
+ src/providers/ldap/ldap_auth.c |    7 +++++++
+ 1 files changed, 7 insertions(+), 0 deletions(-)
+
+diff --git a/src/providers/ldap/ldap_auth.c b/src/providers/ldap/ldap_auth.c
+index b05e3075ce117fad17b87ffde257c80fc035b8c4..1a959d4cc45980fe5dd12db3460cc23f341466fd 100644
+--- a/src/providers/ldap/ldap_auth.c
++++ b/src/providers/ldap/ldap_auth.c
+@@ -557,6 +557,13 @@ static struct tevent_req *auth_send(TALLOC_CTX *memctx,
+     req = tevent_req_create(memctx, &state, struct auth_state);
+     if (!req) return NULL;
+ 
++    /* Treat a zero-length password as a failure */
++    if (password.length == 0) {
++        state->result = SDAP_AUTH_FAILED;
++        tevent_req_done(req);
++        return tevent_req_post(req, ev);
++    }
++
+     state->ev = ev;
+     state->ctx = ctx;
+     state->username = username;
+-- 
+1.7.2.1
+
diff --git a/sssd.spec b/sssd.spec
index 077c3e6..4c12b3e 100644
--- a/sssd.spec
+++ b/sssd.spec
@@ -7,7 +7,7 @@ Name: sssd
 Version: 1.2.2
 #Never reset the Release, always increment it
 #Otherwise we can have issues if library versions do not change
-Release: 19%{?dist}
+Release: 20%{?dist}
 Group: Applications/System
 Summary: System Security Services Daemon
 License: GPLv3+
@@ -23,6 +23,8 @@ BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
 
 ### Patches ###
 
+Patch0001: 0001-Treat-a-zero-length-password-as-a-failure.patch
+
 ### Dependencies ###
 
 Requires: libldb >= 0.9.3
@@ -200,6 +202,7 @@ A dynamically-growing, reference-counted array
 
 %prep
 %setup -q
+%patch0001 -p1
 
 %build
 %configure \
@@ -459,6 +462,10 @@ fi
 %postun -n libref_array -p /sbin/ldconfig
 
 %changelog
+* Tue Aug 24 2010 Stephen Gallagher <sgallagh at redhat.com> - 1.2.2-20
+- Resolves: CVE-2010-2940 - sssd allows null password entry to authenticate
+-                           against LDAP
+
 * Tue Aug 03 2010 Stephen Gallagher <sgallagh at redhat.com> - 1.2.2-19
 - Resolves: rhbz#606887 - sssd stops on upgrade