[hplip/f13/master] Fixed incorrect signal name in setup dialog (bug #653626).

Tim Waugh twaugh at fedoraproject.org
Tue Dec 14 15:55:07 UTC 2010


commit 7ec91682f9dd220be5e7b7246cf8a442a8164562
Author: Tim Waugh <twaugh at redhat.com>
Date:   Tue Dec 14 15:53:12 2010 +0000

    Fixed incorrect signal name in setup dialog (bug #653626).

 hplip-emit-SIGNAL.patch |   16 ++++++++++------
 hplip.spec              |    1 +
 2 files changed, 11 insertions(+), 6 deletions(-)
---
diff --git a/hplip-emit-SIGNAL.patch b/hplip-emit-SIGNAL.patch
index e627fd5..aa72dce 100644
--- a/hplip-emit-SIGNAL.patch
+++ b/hplip-emit-SIGNAL.patch
@@ -1,20 +1,24 @@
 diff -up hplip-3.10.9/ui4/setupdialog.py.emit-SIGNAL hplip-3.10.9/ui4/setupdialog.py
---- hplip-3.10.9/ui4/setupdialog.py.emit-SIGNAL	2010-11-10 18:42:13.000000000 +0100
-+++ hplip-3.10.9/ui4/setupdialog.py	2010-11-11 11:59:47.000000000 +0100
-@@ -868,7 +868,7 @@ class SetupDialog(QDialog, Ui_Dialog):
+--- hplip-3.10.9/ui4/setupdialog.py.emit-SIGNAL	2010-12-14 15:51:43.579041162 +0000
++++ hplip-3.10.9/ui4/setupdialog.py	2010-12-14 15:52:02.631111875 +0000
+@@ -867,8 +867,8 @@ class SetupDialog(QDialog, Ui_Dialog):
+                 self.printer_fax_names_same = False
                  self.printer_name_ok = True
  
-                 self.FaxNameLineEdit.emit(SIGNAL("textChanged(const QString &)"),
+-                self.FaxNameLineEdit.emit(SIGNAL("textChanged(const QString &)"),
 -                            (self.FaxNameLineEdit.text(),))
++                self.FaxNameLineEdit.emit(SIGNAL("textEdited(const QString &)"),
 +                                          self.FaxNameLineEdit.text())
  
          self.setIndicators()
          self.setAddPrinterButton()
-@@ -900,7 +900,7 @@ class SetupDialog(QDialog, Ui_Dialog):
+@@ -899,8 +899,8 @@ class SetupDialog(QDialog, Ui_Dialog):
+                 self.printer_fax_names_same = False
                  self.fax_name_ok = True
  
-                 self.PrinterNameLineEdit.emit(SIGNAL("textChanged(const QString&)"),
+-                self.PrinterNameLineEdit.emit(SIGNAL("textChanged(const QString&)"),
 -                            (self.PrinterNameLineEdit.text(),))
++                self.PrinterNameLineEdit.emit(SIGNAL("textEdited(const QString &)"),
 +                                              self.PrinterNameLineEdit.text())
  
          self.setIndicators()
diff --git a/hplip.spec b/hplip.spec
index 0206dd5..0d16ca3 100644
--- a/hplip.spec
+++ b/hplip.spec
@@ -511,6 +511,7 @@ fi
 
 %changelog
 * Tue Dec 14 2010 Tim Waugh <twaugh at redhat.com> - 3.10.9-9
+- Fixed incorrect signal name in setup dialog (bug #653626).
 - Another missing newline in filter output (Ubuntu #418053).
 - Prevent hpaio segfaulting on invalid URIs (bug #649092).
 - Catch D-Bus exceptions in fax dialog (bug #645316).


More information about the scm-commits mailing list