rpms/audacious-plugins/devel audacious-plugins-2.2-streambrowser-race.patch, NONE, 1.1

Michael Schwendt mschwendt at fedoraproject.org
Wed Feb 3 20:51:14 UTC 2010


Author: mschwendt

Update of /cvs/pkgs/rpms/audacious-plugins/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv18719

Added Files:
	audacious-plugins-2.2-streambrowser-race.patch 
Log Message:
* Wed Feb  3 2010 Michael Schwendt <mschwendt at fedoraproject.org> - 2.2-15
- Prevent race condition crash in streambrowser GUI (#561469).


audacious-plugins-2.2-streambrowser-race.patch:
 streambrowser_win.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

--- NEW FILE audacious-plugins-2.2-streambrowser-race.patch ---
diff -Nur audacious-plugins-2.2-orig/src/streambrowser/gui/streambrowser_win.c audacious-plugins-2.2/src/streambrowser/gui/streambrowser_win.c
--- audacious-plugins-2.2-orig/src/streambrowser/gui/streambrowser_win.c	2009-11-22 23:49:53.000000000 +0100
+++ audacious-plugins-2.2/src/streambrowser/gui/streambrowser_win.c	2010-02-03 21:43:22.000000000 +0100
@@ -44,7 +44,7 @@
 static GtkWidget*		add_button;
 static GtkWidget*		bookmark_button;
 static GtkWidget*		streambrowser_window;
-static GList*			streamdir_gui_list;
+static GList*			streamdir_gui_list = NULL;
 static GtkCellRenderer*	cell_renderer_pixbuf;
 static GtkCellRenderer*	cell_renderer_text;
 
@@ -236,6 +236,8 @@
 void streambrowser_win_set_category_state(streamdir_t *streamdir, category_t *category, gboolean fetching)
 {
 	streamdir_gui_t *streamdir_gui = find_streamdir_gui_by_streamdir(streamdir);
+    if (!streamdir_gui)
+        return;
 	GtkTreeView *tree_view = GTK_TREE_VIEW(streamdir_gui->tree_view);
 	GtkTreeStore *store = GTK_TREE_STORE(gtk_tree_view_get_model(tree_view));
 	GtkTreePath *path;
@@ -260,6 +262,8 @@
 void streambrowser_win_set_streaminfo_state(streamdir_t *streamdir, category_t *category, streaminfo_t *streaminfo, gboolean fetching)
 {
 	streamdir_gui_t *streamdir_gui = find_streamdir_gui_by_streamdir(streamdir);
+    if (!streamdir_gui)
+        return;
 	GtkTreeView *tree_view = GTK_TREE_VIEW(streamdir_gui->tree_view);
 	GtkTreeStore *store = GTK_TREE_STORE(gtk_tree_view_get_model(tree_view));
 	GtkTreePath *path;



More information about the scm-commits mailing list