rpms/audacious-plugins/F-12 audacious-plugins-2.2-neon-error-handling.patch, NONE, 1.1 audacious-plugins.spec, 1.88, 1.89

[Michael Schwendt]

Author: mschwendt

Update of /cvs/pkgs/rpms/audacious-plugins/F-12
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv8140

Modified Files:
	audacious-plugins.spec 
Added Files:
	audacious-plugins-2.2-neon-error-handling.patch 
Log Message:
* Fri Feb  5 2010 Michael Schwendt <mschwendt at fedoraproject.org> - 2.2-18
- Destroy neon request+session if ne_read_response_block failed and
  closed the connection. That way we don't call neon lib again with old 
  request+session which then crashes (#562164).


audacious-plugins-2.2-neon-error-handling.patch:
 neon.c |    4 ++++
 1 file changed, 4 insertions(+)

--- NEW FILE audacious-plugins-2.2-neon-error-handling.patch ---
diff -Nur audacious-plugins-2.2-orig/src/neon/neon.c audacious-plugins-2.2/src/neon/neon.c
--- audacious-plugins-2.2-orig/src/neon/neon.c	2009-11-22 23:49:53.000000000 +0100
+++ audacious-plugins-2.2/src/neon/neon.c	2010-02-05 19:58:04.000000000 +0100
@@ -765,6 +765,10 @@
             _LEAVE 1;
         } else {
             _ERROR("<%p> Error while reading from the network", h);
+            ne_request_destroy(h->request);
+            h->request = NULL;
+            ne_session_destroy(h->session);
+            h->session = NULL;
             _LEAVE -1;
         }
     }


Index: audacious-plugins.spec
===================================================================
RCS file: /cvs/pkgs/rpms/audacious-plugins/F-12/audacious-plugins.spec,v
retrieving revision 1.88
retrieving revision 1.89
diff -u -p -r1.88 -r1.89
--- audacious-plugins.spec	4 Feb 2010 12:25:36 -0000	1.88
+++ audacious-plugins.spec	5 Feb 2010 19:17:19 -0000	1.89
@@ -5,7 +5,7 @@
 
 Name: audacious-plugins
 Version: 2.2
-Release: 17%{?dist}
+Release: 18%{?dist}
 Summary: Plugins for the Audacious media player
 Group: Applications/Multimedia
 URL: http://audacious-media-player.org/
@@ -51,6 +51,8 @@ Patch11: audacious-plugins-2.2-streambro
 # plus: hardcoded libdir replacement
 # plus: fix dialog
 Patch12: audacious-plugins-2.2-ladspa.patch
+#
+Patch13: audacious-plugins-2.2-neon-error-handling.patch
 
 BuildRequires: audacious-devel >= %{aud_ver}
 BuildRequires: jack-audio-connection-kit-devel libsamplerate-devel
@@ -193,6 +195,7 @@ in Vortex (.vtx) format.
 %patch10 -p1 -b .lds-out-of-bounds
 %patch11 -p1 -b .streambrowser-race
 %patch12 -p1 -b .ladspa
+%patch13 -p1 -b .neon-error-handling
 
 for i in src/ladspa/ladspa.c
 do
@@ -293,6 +296,11 @@ update-desktop-database &> /dev/null || 
 
 
 %changelog
+* Fri Feb  5 2010 Michael Schwendt <mschwendt at fedoraproject.org> - 2.2-18
+- Destroy neon request+session if ne_read_response_block failed and
+  closed the connection. That way we don't call neon lib again with old 
+  request+session which then crashes (#562164).
+
 * Thu Feb  4 2010 Michael Schwendt <mschwendt at fedoraproject.org> - 2.2-17
 - Fix non-top-level ladspa plugin dialogs.