rpms/kernel/F-11 kernel-signal.c-fix-kernel-information-leak-with-print-fatal-signals-1.patch, NONE, 1.1.2.1 kernel.spec, 1.1784.2.3, 1.1784.2.4

[Chuck Ebbert]

Author: cebbert

Update of /cvs/pkgs/rpms/kernel/F-11
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv24795

Modified Files:
      Tag: private-fedora-11-2_6_30
	kernel.spec 
Added Files:
      Tag: private-fedora-11-2_6_30
	kernel-signal.c-fix-kernel-information-leak-with-print-fatal-signals-1.patch 
Log Message:
CVE-2010-0003: kernel: infoleak if print-fatal-signals=1

kernel-signal.c-fix-kernel-information-leak-with-print-fatal-signals-1.patch:
 signal.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- NEW FILE kernel-signal.c-fix-kernel-information-leak-with-print-fatal-signals-1.patch ---
>From b45c6e76bc2c72f6426c14bed64fdcbc9bf37cb0 Mon Sep 17 00:00:00 2001
From: Andi Kleen <andi at firstfloor.org>
Date: Fri, 8 Jan 2010 14:42:52 -0800
Subject: kernel/signal.c: fix kernel information leak with print-fatal-signals=1

From: Andi Kleen <andi at firstfloor.org>

commit b45c6e76bc2c72f6426c14bed64fdcbc9bf37cb0 upstream.

When print-fatal-signals is enabled it's possible to dump any memory
reachable by the kernel to the log by simply jumping to that address from
user space.

Or crash the system if there's some hardware with read side effects.

The fatal signals handler will dump 16 bytes at the execution address,
which is fully controlled by ring 3.

In addition when something jumps to a unmapped address there will be up to
16 additional useless page faults, which might be potentially slow (and at
least is not very efficient)

Fortunately this option is off by default and only there on i386.

But fix it by checking for kernel addresses and also stopping when there's
a page fault.

Signed-off-by: Andi Kleen <ak at linux.intel.com>
Cc: Ingo Molnar <mingo at elte.hu>
Cc: Oleg Nesterov <oleg at redhat.com>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>

---
 kernel/signal.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -939,7 +939,8 @@ static void print_fatal_signal(struct pt
 		for (i = 0; i < 16; i++) {
 			unsigned char insn;
 
-			__get_user(insn, (unsigned char *)(regs->ip + i));
+			if (get_user(insn, (unsigned char *)(regs->ip + i)))
+				break;
 			printk("%02x ", insn);
 		}
 	}


Index: kernel.spec
===================================================================
RCS file: /cvs/pkgs/rpms/kernel/F-11/kernel.spec,v
retrieving revision 1.1784.2.3
retrieving revision 1.1784.2.4
diff -u -p -r1.1784.2.3 -r1.1784.2.4
--- kernel.spec	19 Jan 2010 19:57:24 -0000	1.1784.2.3
+++ kernel.spec	19 Jan 2010 20:01:51 -0000	1.1784.2.4
@@ -852,6 +852,8 @@ Patch16473: linux-2.6-libertas-crash.pat
 Patch16500: ipv6-skb_dst-can-be-null-in-ipv6_hop_jumbo.patch
 # cve-2010-0007
 Patch16501: netfilter-ebtables-enforce-cap_net_admin.patch
+# cve-2010-0003
+Patch16502: kernel-signal.c-fix-kernel-information-leak-with-print-fatal-signals-1.patch
 
 %endif
 
@@ -1602,6 +1604,8 @@ ApplyPatch linux-2.6-libertas-crash.patc
 ApplyPatch ipv6-skb_dst-can-be-null-in-ipv6_hop_jumbo.patch
 # cve-2010-0007
 ApplyPatch netfilter-ebtables-enforce-cap_net_admin.patch
+# cve-2010-0003
+ApplyPatch kernel-signal.c-fix-kernel-information-leak-with-print-fatal-signals-1.patch
 
 # END OF PATCH APPLICATIONS
 
@@ -2191,6 +2195,9 @@ fi
 # and build.
 
 %changelog
+* Tue Jan 19 2010 Chuck Ebbert <cebbert at redhat.com>  2.6.30.10-105.2.4
+- CVE-2010-0003: kernel: infoleak if print-fatal-signals=1
+
 * Tue Jan 19 2010 Chuck Ebbert <cebbert at redhat.com>  2.6.30.10-105.2.3
 - CVE-2010-0007: kernel: normal users can modify ebtables rules (#555238)