rpms/audacious-plugins/devel audacious-plugins-2.2-neon-session-destroy.patch, NONE, 1.1 audacious-plugins.spec, 1.83, 1.84
Michael Schwendt
mschwendt at fedoraproject.org
Mon Jan 25 09:39:23 UTC 2010
Author: mschwendt
Update of /cvs/pkgs/rpms/audacious-plugins/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv7787
Modified Files:
audacious-plugins.spec
Added Files:
audacious-plugins-2.2-neon-session-destroy.patch
Log Message:
* Mon Jan 25 2010 Michael Schwendt <mschwendt at fedoraproject.org> - 2.2-13
- In neon transport, after error handling set destroyed session
pointers to NULL, so vfs seek doesn't crash.
audacious-plugins-2.2-neon-session-destroy.patch:
neon.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
--- NEW FILE audacious-plugins-2.2-neon-session-destroy.patch ---
It's just bad to de-couple state and NULL ptrs.
diff -Nur audacious-plugins-fedora-2.2-neon1/src/neon/neon.c audacious-plugins-fedora-2.2-neon2/src/neon/neon.c
--- audacious-plugins-fedora-2.2-neon1/src/neon/neon.c 2010-01-25 09:46:23.000000000 +0100
+++ audacious-plugins-fedora-2.2-neon2/src/neon/neon.c 2010-01-25 09:51:17.000000000 +0100
@@ -727,11 +727,13 @@
_LEAVE 0;
} else if (-1 == ret) {
ne_session_destroy(handle->session);
+ handle->session = NULL;
_LEAVE -1;
}
_DEBUG("<%p> Following redirect...", handle);
ne_session_destroy(handle->session);
+ handle->session = NULL;
}
/*
@@ -945,7 +947,9 @@
}
_DEBUG("<%p> Destroying session", h);
- ne_session_destroy(h->session);
+ if (NULL != h->session) {
+ ne_session_destroy(h->session);
+ }
handle_free(h);
@@ -1359,7 +1363,10 @@
if (NULL != h->request) {
ne_request_destroy(h->request);
}
- ne_session_destroy(h->session);
+ if (NULL != h->session) {
+ ne_session_destroy(h->session);
+ h->session = NULL;
+ }
reset_rb(&h->rb);
if (0 != open_handle(h, newpos)) {
Index: audacious-plugins.spec
===================================================================
RCS file: /cvs/pkgs/rpms/audacious-plugins/devel/audacious-plugins.spec,v
retrieving revision 1.83
retrieving revision 1.84
diff -u -p -r1.83 -r1.84
--- audacious-plugins.spec 24 Jan 2010 07:48:11 -0000 1.83
+++ audacious-plugins.spec 25 Jan 2010 09:39:23 -0000 1.84
@@ -5,7 +5,7 @@
Name: audacious-plugins
Version: 2.2
-Release: 12%{?dist}
+Release: 13%{?dist}
Summary: Plugins for the Audacious media player
Group: Applications/Multimedia
URL: http://audacious-media-player.org/
@@ -38,6 +38,8 @@ Patch5: audacious-plugins-2.2-alarm.patc
Patch6: audacious-plugins-2.2-xspf-base.patch
# merged upstream (AUDPLUG-160)
Patch7: audacious-plugins-2.2-svis_expose.patch
+#
+Patch8: audacious-plugins-2.2-neon-session-destroy.patch
BuildRequires: audacious-devel >= %{aud_ver}
BuildRequires: jack-audio-connection-kit-devel libsamplerate-devel
@@ -175,6 +177,7 @@ in Vortex (.vtx) format.
%patch5 -p1 -b .alarm
%patch6 -p1 -b .xspf
%patch7 -p1 -b .svis_expose
+%patch8 -p1 -b .neon-session-destroy
sed -i '\,^.SILENT:,d' buildsys.mk.in
@@ -268,6 +271,10 @@ update-desktop-database &> /dev/null ||
%changelog
+* Mon Jan 25 2010 Michael Schwendt <mschwendt at fedoraproject.org> - 2.2-13
+- In neon transport, after error handling set destroyed session
+ pointers to NULL, so vfs seek doesn't crash.
+
* Fri Jan 22 2010 Adrian Reber <adrian at lisas.de> - 2.2-12
- Rebuild for libcdio-0.82
More information about the scm-commits
mailing list