rpms/mgetty/devel mgetty.spec,1.54,1.55

[Jiri Skala]

Author: jskala

Update of /cvs/extras/rpms/mgetty/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv24079

Modified Files:
	mgetty.spec 
Log Message:
* Mon Jan 25 2010 Jiri Skala <jskala at redhat.com> - 1.1.36-6
- modified spec to make rpmlint more silent
- added comments to spec to surviving rpmlint W and E



Index: mgetty.spec
===================================================================
RCS file: /cvs/extras/rpms/mgetty/devel/mgetty.spec,v
retrieving revision 1.54
retrieving revision 1.55
diff -u -p -r1.54 -r1.55
--- mgetty.spec	25 Jan 2010 16:47:55 -0000	1.54
+++ mgetty.spec	28 Jan 2010 14:33:50 -0000	1.55
@@ -137,7 +137,9 @@ mkdir -p $RPM_BUILD_ROOT{%{_mandir},%{_s
 %define instflags CFLAGS="$RPM_OPT_FLAGS -Wall -DAUTO_PPP" prefix=$RPM_BUILD_ROOT%{_prefix} spool=$RPM_BUILD_ROOT%{_var}/spool BINDIR=$RPM_BUILD_ROOT%{_bindir} SBINDIR=$RPM_BUILD_ROOT%{_sbindir} LIBDIR=$RPM_BUILD_ROOT%{_libdir}/mgetty+sendfax HELPDIR=$RPM_BUILD_ROOT%{_libdir}/mgetty+sendfax CONFDIR=$RPM_BUILD_ROOT%{_sysconfdir}/mgetty+sendfax MANDIR=$RPM_BUILD_ROOT%{_mandir} MAN1DIR=$RPM_BUILD_ROOT%{_mandir}/man1 MAN4DIR=$RPM_BUILD_ROOT%{_mandir}/man4 MAN5DIR=$RPM_BUILD_ROOT%{_mandir}/man5 MAN8DIR=$RPM_BUILD_ROOT%{_mandir}/man8 INFODIR=$RPM_BUILD_ROOT%{_infodir} ECHO='echo -e' INSTALL=%{__install}
 
 make install %instflags
+# the non-standard executable permissions are used due to security
 install -m700 callback/callback $RPM_BUILD_ROOT%{_sbindir}
+# helper tests internally usage of suid - this is an intention
 install -m4711 callback/ct $RPM_BUILD_ROOT%{_bindir}
 
 mv $RPM_BUILD_ROOT%{_sbindir}/mgetty $RPM_BUILD_ROOT/sbin
@@ -152,6 +154,7 @@ make -C tools install %instflags
 mkdir -p $RPM_BUILD_ROOT%{_var}/spool/voice/{messages,incoming}
 make -C voice install %instflags
 mv $RPM_BUILD_ROOT%{_sbindir}/vgetty $RPM_BUILD_ROOT/sbin
+# the non-standard permissions are used due to security
 install -m 600 -c voice/voice.conf-dist $RPM_BUILD_ROOT%{_sysconfdir}/mgetty+sendfax/voice.conf
 
 # don't ship documentation that is executable...
@@ -228,6 +231,7 @@ fi
 %dir %{_libdir}/mgetty+sendfax
 %{_libdir}/mgetty+sendfax/cour25.pbm
 %{_libdir}/mgetty+sendfax/cour25n.pbm
+# helper tests internally usage of suid - this is an intention
 %attr(04711,fax,root) %{_libdir}/mgetty+sendfax/faxq-helper
 %{_mandir}/man1/pbm2g3.1*
 %{_mandir}/man1/mgetty_fax.1*
@@ -244,8 +248,10 @@ fi
 %dir %{_sysconfdir}/mgetty+sendfax
 %config(noreplace) %{_sysconfdir}/mgetty+sendfax/sendfax.config
 %config(noreplace) %{_sysconfdir}/mgetty+sendfax/faxrunq.config
+# sample config file doesn't use noreplace option to be installed always latest ver.
 %config %{_sysconfdir}/mgetty+sendfax/faxspool.rules.sample
 %config(noreplace) %{_sysconfdir}/mgetty+sendfax/faxheader
+# logrotate file name uses only sub-package name
 %config(noreplace) %{_sysconfdir}/logrotate.d/sendfax
 
 %files voice
@@ -309,6 +315,7 @@ fi
 %{_mandir}/man8/vgetty.8*
 %dir %{_sysconfdir}/mgetty+sendfax
 %config(noreplace) %{_sysconfdir}/mgetty+sendfax/voice.conf
+# logrotate file name uses only sub-package name
 %config(noreplace) %{_sysconfdir}/logrotate.d/vgetty
 %config(noreplace) %{_sysconfdir}/logrotate.d/vm
 
@@ -323,6 +330,7 @@ fi
 %changelog
 * Mon Jan 25 2010 Jiri Skala <jskala at redhat.com> - 1.1.36-6
 - modified spec to make rpmlint more silent
+- added comments to spec to surviving rpmlint W and E
 
 * Mon Sep 14 2009 Jiri Skala <jskala at redhat.com> - 1.1.36-5
 - fixed #516001 - Errors installing mgetty with --excludedocs