[audacious-plugins] - Prevent buffer realloc crash in cue.c playlist_load_cue (#649645).

Michael Schwendt mschwendt at fedoraproject.org
Thu Nov 4 15:40:13 UTC 2010


commit b790c5fa8ba11ca210029d00940e1bb1f357166e
Author: Michael Schwendt <mschwendt at fedoraproject.org>
Date:   Thu Nov 4 16:40:06 2010 +0100

    - Prevent buffer realloc crash in cue.c playlist_load_cue (#649645).

 audacious-plugins-2.4.0-cue-crash-649645.patch |   12 ++++++++++++
 audacious-plugins.spec                         |    8 +++++++-
 2 files changed, 19 insertions(+), 1 deletions(-)
---
diff --git a/audacious-plugins-2.4.0-cue-crash-649645.patch b/audacious-plugins-2.4.0-cue-crash-649645.patch
new file mode 100644
index 0000000..86ca352
--- /dev/null
+++ b/audacious-plugins-2.4.0-cue-crash-649645.patch
@@ -0,0 +1,12 @@
+diff -Nur audacious-plugins-fedora-2.4.0-orig/src/cue/cue.c audacious-plugins-fedora-2.4.0/src/cue/cue.c
+--- audacious-plugins-fedora-2.4.0-orig/src/cue/cue.c	2010-08-26 01:07:50.000000000 +0200
++++ audacious-plugins-fedora-2.4.0/src/cue/cue.c	2010-11-04 16:34:59.528946835 +0100
+@@ -72,7 +72,7 @@
+ 
+ static void playlist_load_cue (const gchar * cue_filename, gint at)
+ {
+-    void * buffer;
++    void * buffer = NULL;
+     gint64 size;
+     vfs_file_get_contents (cue_filename, & buffer, & size);
+     if (buffer == NULL)
diff --git a/audacious-plugins.spec b/audacious-plugins.spec
index 811a5e4..4aa1c69 100644
--- a/audacious-plugins.spec
+++ b/audacious-plugins.spec
@@ -6,7 +6,7 @@
 
 Name: audacious-plugins
 Version: 2.4.0
-Release: 6%{?dist}
+Release: 7%{?dist}
 Summary: Plugins for the Audacious audio player
 Group: Applications/Multimedia
 URL: http://audacious-media-player.org/
@@ -33,6 +33,8 @@ Patch4: audacious-plugins-2.4.0-scrobbler-no-null.diff.patch
 Patch5: audacious-plugins-2.4.0-psf-update.patch
 # from upstream hg
 Patch6: audacious-plugins-2.4.0-blur-scope-update.patch
+# submitted, AUDPLUG-299
+Patch7: audacious-plugins-2.4.0-cue-crash-649645.patch
 
 BuildRequires: audacious-devel >= %{aud_ver}
 BuildRequires: gettext
@@ -145,6 +147,7 @@ providers may build it with libsidplay 2 instead.
 %patch4 -p1 -b .scrobbler-no-null
 %patch5 -p1 -b .psf-update
 %patch6 -p1 -b .blur-scope-update
+%patch7 -p1 -b .cue-crash-649645
 
 for i in src/ladspa/ladspa.c
 do
@@ -234,6 +237,9 @@ update-desktop-database &> /dev/null || :
 
 
 %changelog
+* Thu Nov  4 2010 Michael Schwendt <mschwendt at fedoraproject.org> - 2.4.0-7
+- Prevent buffer realloc crash in cue.c playlist_load_cue (#649645).
+
 * Fri Oct  8 2010 Michael Schwendt <mschwendt at fedoraproject.org> - 2.4.0-6
 - Merge updated blur-scope plugin to fix segfaults.
 


More information about the scm-commits mailing list