[system-config-printer] Removed calls to pynotify.Notification.attach_to_status_icon() (bug #657722).

Tim Waugh twaugh at fedoraproject.org
Tue Nov 30 13:13:14 UTC 2010


commit f5a8176626de6b83ae39fd2cdac71c3f66f6db13
Author: Tim Waugh <twaugh at redhat.com>
Date:   Tue Nov 30 13:08:17 2010 +0000

    Removed calls to pynotify.Notification.attach_to_status_icon() (bug #657722).

 system-config-printer-attach-to-status-icon.patch |   23 +++++++++++++++++++++
 system-config-printer.spec                        |    8 ++++++-
 2 files changed, 30 insertions(+), 1 deletions(-)
---
diff --git a/system-config-printer-attach-to-status-icon.patch b/system-config-printer-attach-to-status-icon.patch
new file mode 100644
index 0000000..8bd1997
--- /dev/null
+++ b/system-config-printer-attach-to-status-icon.patch
@@ -0,0 +1,23 @@
+diff -up system-config-printer-1.2.95/jobviewer.py.attach-to-status-icon system-config-printer-1.2.95/jobviewer.py
+--- system-config-printer-1.2.95/jobviewer.py.attach-to-status-icon	2010-11-24 17:26:25.000000000 +0000
++++ system-config-printer-1.2.95/jobviewer.py	2010-11-30 13:07:10.328607041 +0000
+@@ -1673,9 +1673,6 @@ class JobViewer (GtkGUI):
+                               self.on_state_reason_notification_closed)
+         self.state_reason_notifications[reason.get_tuple ()] = notification
+         self.set_statusicon_visibility ()
+-        if not self.notify_has_persistence:
+-            notification.attach_to_status_icon (self.statusicon)
+-
+         try:
+             notification.show ()
+         except gobject.GError:
+@@ -1731,9 +1728,6 @@ class JobViewer (GtkGUI):
+         notification.set_data ('jobid', jobid)
+         self.completed_job_notifications[jobid] = notification
+         self.set_statusicon_visibility ()
+-        if not self.notify_has_persistence:
+-            notification.attach_to_status_icon (self.statusicon)
+-
+         try:
+             notification.show ()
+         except gobject.GError:
diff --git a/system-config-printer.spec b/system-config-printer.spec
index 419daa7..86ac926 100644
--- a/system-config-printer.spec
+++ b/system-config-printer.spec
@@ -5,11 +5,12 @@
 Summary: A printer administration tool
 Name: system-config-printer
 Version: 1.2.95
-Release: 2%{?dist}
+Release: 3%{?dist}
 License: GPLv2+
 URL: http://cyberelk.net/tim/software/system-config-printer/
 Group: System Environment/Base
 Source0: http://cyberelk.net/tim/data/system-config-printer/1.2/%{name}-%{version}.tar.xz
+Patch1: system-config-printer-attach-to-status-icon.patch
 BuildRequires: cups-devel >= 1.2
 BuildRequires: desktop-file-utils >= 0.2.92
 BuildRequires: gettext-devel
@@ -65,6 +66,7 @@ printers.
 
 %prep
 %setup -q
+%patch1 -p1 -b .attach-to-status-icon
 
 %build
 %configure --with-udev-rules
@@ -174,6 +176,10 @@ rm -rf %buildroot
 exit 0
 
 %changelog
+* Tue Nov 30 2010 Tim Waugh <twaugh at redhat.com> - 1.2.95-3
+- Removed calls to pynotify.Notification.attach_to_status_icon()
+  (bug #657722).
+
 * Fri Nov 26 2010 Jiri Popelka <jpopelka at redhat.com> 1.2.95-2
 - Added %%ghost to /var/run/udev-configure-printer/usb-uris (bug #656698).
 


More information about the scm-commits mailing list