[libdbi-drivers/f12/master] Do not use -ffast-math.
Tom Lane
tgl at fedoraproject.org
Sat Sep 4 00:30:03 UTC 2010
commit bddfb45a738a303fb5055ec59591457225503333
Author: Tom Lane <tgl at redhat.com>
Date: Fri Sep 3 20:29:48 2010 -0400
Do not use -ffast-math.
libdbi-drivers-cflags.patch | 6 ++++--
libdbi-drivers.spec | 7 ++++++-
2 files changed, 10 insertions(+), 3 deletions(-)
---
diff --git a/libdbi-drivers-cflags.patch b/libdbi-drivers-cflags.patch
index b01cfdd..4d2b744 100644
--- a/libdbi-drivers-cflags.patch
+++ b/libdbi-drivers-cflags.patch
@@ -1,4 +1,6 @@
-Ensure desirable compile flags are used.
+Ensure desirable compile flags are used. We want RPM_OPT_FLAGS rather than
+upstream's idea of suitable optimization flags, per Fedora packaging
+guidelines, and we *don't* want -ffast-math, per bug #629964.
diff -Naur libdbi-drivers-0.8.2-1.orig/configure.in libdbi-drivers-0.8.2-1/configure.in
@@ -9,7 +11,7 @@ diff -Naur libdbi-drivers-0.8.2-1.orig/configure.in libdbi-drivers-0.8.2-1/confi
*-*-linux*)
DEBUG="-g -Wall -D_REENTRANT -D__NO_MATH_INLINES -fsigned-char"
- CFLAGS="-O20 -ffast-math -D_REENTRANT -fsigned-char"
-+ CFLAGS="-ffast-math -D_REENTRANT -fsigned-char $RPM_OPT_FLAGS"
++ CFLAGS="-D_REENTRANT -fsigned-char $RPM_OPT_FLAGS"
PROFILE="-pg -g -O20 -ffast-math -D_REENTRANT -fsigned-char";;
sparc-sun-*)
DEBUG="-g -Wall -D__NO_MATH_INLINES -fsigned-char -mv8"
diff --git a/libdbi-drivers.spec b/libdbi-drivers.spec
index a1ebf6a..50a2f30 100644
--- a/libdbi-drivers.spec
+++ b/libdbi-drivers.spec
@@ -1,7 +1,7 @@
Summary: Database-specific drivers for libdbi
Name: libdbi-drivers
Version: 0.8.3
-Release: 5%{?dist}
+Release: 6%{?dist}
Group: Development/Libraries
License: LGPLv2+
URL: http://libdbi-drivers.sourceforge.net/
@@ -122,6 +122,11 @@ rm -rf $RPM_BUILD_ROOT%{_docdir}/libdbi-drivers
%{_libdir}/dbd/libdbdsqlite3.*
%changelog
+* Fri Sep 3 2010 Tom Lane <tgl at redhat.com> 0.8.3-6
+- Do not use -ffast-math; it breaks things and seems quite unlikely to offer
+ any useful performance benefit for this type of package, anyway
+Resolves: #629964
+
* Fri Jul 24 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.8.3-5
- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
More information about the scm-commits
mailing list