[efax] bz#225719, review

[Than Ngo]

commit f9ec415ced84535c04509322bb743390c8fb3341
Author: Than Ngo <than at redhat.com>
Date:   Wed Sep 29 15:28:04 2010 +0200

    bz#225719, review

 efax.spec |   15 +++++++++++----
 1 files changed, 11 insertions(+), 4 deletions(-)
---
diff --git a/efax.spec b/efax.spec
index e193ffc..965b452 100644
--- a/efax.spec
+++ b/efax.spec
@@ -1,11 +1,12 @@
-Summary: A program for faxing using a Class 1, 2 or 2.0 fax modem.
+Summary: A program for faxing using a Class 1, 2 or 2.0 fax modem
 Name: efax
 Version: 0.9a
-Release: 7.001114%{?dist}
+Release: 8.001114%{?dist}
 License: GPLv2+
 Group: Applications/Communications
 Url: http://www.cce.com/efax/
 Source: http://www.cce.com/efax/download/%{name}-%{version}-001114.tar.gz
+Source1: logrotate-efax
 Patch0: efax-0.9-config.patch
 Patch1: efax-0.9-numlines.patch
 Patch2: efax08a-time.patch
@@ -19,7 +20,7 @@ Patch10: efax-0.9a-001114-crash.patch
 
 ExcludeArch: s390 s390x
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-Requires: make
+BuildRequires: make
 Requires: netpbm-progs
 
 %description
@@ -44,7 +45,7 @@ Class 1, 2 or 2.0 fax modem.
 %patch10 -p1 -b .crash
 
 %build
-make RPM_OPT_FLAGS="-ansi $RPM_OPT_FLAGS"
+make %{?_smp_mflags} RPM_OPT_FLAGS="-ansi $RPM_OPT_FLAGS"
 
 %install
 rm -rf %{buildroot}
@@ -54,6 +55,8 @@ mkdir -p %{buildroot}%{_localstatedir}/spool/fax
 mkdir -p %{buildroot}%{_localstatedir}/log/fax
 
 make BINDIR=%{buildroot}%{_bindir} MANDIR=%{buildroot}%{_mandir} install
+mkdir -p %{buildroot}/etc/logrotate.d/
+install -c -m 644 %{SOURCE1} %{buildroot}/etc/logrotate.d/efax
 
 %clean
 rm -rf %{buildroot}
@@ -61,12 +64,16 @@ rm -rf %{buildroot}
 %files
 %defattr(-, root, root, -)
 %doc README COPYING
+%config(noreplace) /etc/logrotate.d/efax
 %{_bindir}/*
 %{_mandir}/*/*
 %dir %{_localstatedir}/spool/fax
 %dir %{_localstatedir}/log/fax
 
 %changelog
+* Wed Sep 29 2010 Than Ngo <than at redhat.com> - 0.9a-8.001114
+- bz#225719, review
+
 * Mon Dec 07 2009 Than Ngo <than at redhat.com> - 0.9a-7.001114
 - fix url