[rocs] ValueModifier must be exported because it is used in the plugins.

Kevin Kofler kkofler at fedoraproject.org
Fri Dec 2 23:32:17 UTC 2011


commit 80cf56a62d5d16c583d6a458aa2c9e7ff232ebdd
Author: Kevin Kofler <Kevin at tigcc.ticalc.org>
Date:   Sat Dec 3 00:32:05 2011 +0100

    ValueModifier must be exported because it is used in the plugins.

 rocs-4.7.80-export.patch   |   32 ++++++++++++++++++++++++++++++++
 rocs-4.7.80-optflags.patch |    8 ++++----
 rocs.spec                  |    4 ++++
 3 files changed, 40 insertions(+), 4 deletions(-)
---
diff --git a/rocs-4.7.80-export.patch b/rocs-4.7.80-export.patch
new file mode 100644
index 0000000..94d3812
--- /dev/null
+++ b/rocs-4.7.80-export.patch
@@ -0,0 +1,32 @@
+From 1bf8f7900513ed7ed49078780e80e0dd5c7ab500 Mon Sep 17 00:00:00 2001
+Message-Id: <1bf8f7900513ed7ed49078780e80e0dd5c7ab500.1322868562.git.kevin.kofler at chello.at>
+From: Kevin Kofler <kevin.kofler at chello.at>
+Date: Sat, 3 Dec 2011 00:29:12 +0100
+Subject: [PATCH] ValueModifier must be exported because it is used in the
+ plugins.
+
+This bug was covered on GNU/Linux by the visibility flags getting overwritten
+(which I fixed with the previous commit). This is a compilation fix for targets
+which default to hidden visibility.
+
+CCMAIL: release-team at kde.org
+---
+ src/Core/Modifiers/ValueModifier.h |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/src/Core/Modifiers/ValueModifier.h b/src/Core/Modifiers/ValueModifier.h
+index d6bf4f0..6b30679 100644
+--- a/src/Core/Modifiers/ValueModifier.h
++++ b/src/Core/Modifiers/ValueModifier.h
+@@ -29,7 +29,7 @@
+ #include "Rocs_Typedefs.h"
+ 
+ 
+-class ValueModifier
++class ROCSLIB_EXPORT ValueModifier
+ {
+ 
+ public:
+-- 
+1.7.6.4
+
diff --git a/rocs-4.7.80-optflags.patch b/rocs-4.7.80-optflags.patch
index 3ab44b5..46ce43b 100644
--- a/rocs-4.7.80-optflags.patch
+++ b/rocs-4.7.80-optflags.patch
@@ -1,7 +1,7 @@
-From dc3089d4717334d7aa60d179ef8ddecf7dac8d30 Mon Sep 17 00:00:00 2001
-Message-Id: <dc3089d4717334d7aa60d179ef8ddecf7dac8d30.1322867115.git.Kevin at tigcc.ticalc.org>
-From: Kevin Kofler <Kevin at tigcc.ticalc.org>
-Date: Sat, 3 Dec 2011 00:05:08 +0100
+From a2f525ffd6f28a635ba3231734bdba9747c8ef29 Mon Sep 17 00:00:00 2001
+Message-Id: <a2f525ffd6f28a635ba3231734bdba9747c8ef29.1322867596.git.kevin.kofler at chello.at>
+From: Kevin Kofler <kevin.kofler at chello.at>
+Date: Sat, 3 Dec 2011 00:13:11 +0100
 Subject: [PATCH] CMakeLists.txt: Don't trash CMAKE_CXX_FLAGS.
 
 https://bugzilla.redhat.com/show_bug.cgi?id=759593
diff --git a/rocs.spec b/rocs.spec
index 5d69498..c0f6ed4 100644
--- a/rocs.spec
+++ b/rocs.spec
@@ -11,6 +11,9 @@ Source0: http://download.kde.org/unstable/%{version}/src/%{name}-%{version}.tar.
 # upstream patches
 # CMakeLists.txt: Don't trash CMAKE_CXX_FLAGS (#759593)
 Patch100: rocs-4.7.80-optflags.patch
+# ValueModifier must be exported because it is used in the plugins.
+# Fixes the compilation with the above patch.
+Patch101: rocs-4.7.80-export.patch
 
 BuildRequires: boost-devel
 BuildRequires: desktop-file-utils
@@ -44,6 +47,7 @@ Requires: kdelibs4-devel
 %prep
 %setup -q
 %patch100 -p1 -b .optflags
+%patch101 -p1 -b .export
 
 
 %build


More information about the scm-commits mailing list