[icu/f16] Resolves: rhbz#766542 CVE-2011-4599 Stack-based buffer overflow

[Eike Rathke]

commit 67840b8bb8b4d5cab6137c1340fdc4d88c6016eb
Author: Eike Rathke <erack at redhat.com>
Date:   Tue Dec 13 21:37:01 2011 +0100

    Resolves: rhbz#766542 CVE-2011-4599 Stack-based buffer overflow

 icu.8984.CVE-2011-4599.patch |   20 ++++++++++++++++++++
 icu.spec                     |    8 +++++++-
 2 files changed, 27 insertions(+), 1 deletions(-)
---
diff --git a/icu.8984.CVE-2011-4599.patch b/icu.8984.CVE-2011-4599.patch
new file mode 100644
index 0000000..fc5fd63
--- /dev/null
+++ b/icu.8984.CVE-2011-4599.patch
@@ -0,0 +1,20 @@
+--- icu/source/common/uloc.c
++++ icu/source/common/uloc.c
+@@ -1797,7 +1797,7 @@
+                 int32_t variantLen = _deleteVariant(variant, uprv_min(variantSize, (nameCapacity-len)), variantToCompare, n);
+                 len -= variantLen;
+                 if (variantLen > 0) {
+-                    if (name[len-1] == '_') { /* delete trailing '_' */
++                    if (len > 0 && name[len-1] == '_') { /* delete trailing '_' */
+                         --len;
+                     }
+                     addKeyword = VARIANT_MAP[j].keyword;
+@@ -1805,7 +1805,7 @@
+                     break;
+                 }
+             }
+-            if (name[len-1] == '_') { /* delete trailing '_' */
++            if (len > 0 && len <= nameCapacity && name[len-1] == '_') { /* delete trailing '_' */
+                 --len;
+             }
+         }
diff --git a/icu.spec b/icu.spec
index 162d221..53113c6 100644
--- a/icu.spec
+++ b/icu.spec
@@ -1,6 +1,6 @@
 Name:      icu
 Version:   4.6
-Release:   2%{?dist}
+Release:   3%{?dist}
 Summary:   International Components for Unicode
 Group:     Development/Tools
 License:   MIT and UCD and Public Domain
@@ -12,6 +12,7 @@ Requires: lib%{name} = %{version}-%{release}
 
 Patch1: icu.8198.revert.icu5431.patch
 Patch2: icu.8320.freeserif.crash.patch
+Patch3: icu.8984.CVE-2011-4599.patch
 
 %description
 Tools and utilities for developing with icu.
@@ -53,6 +54,7 @@ BuildArch: noarch
 %setup -q -n %{name}
 %patch1 -p2 -R -b .icu8198.revert.icu5431.patch
 %patch2 -p1 -b .icu8320.freeserif.crash.patch
+%patch3 -p1 -b .icu8984.CVE-2011-4599.patch
 
 %build
 cd source
@@ -140,6 +142,10 @@ rm -rf $RPM_BUILD_ROOT
 %doc source/__docs/%{name}/html/*
 
 %changelog
+* Tue Dec 13 2011 Eike Rathke <erack at redhat.com> - 4.6-3
+- Resolves: rhbz#766542 CVE-2011-4599 Stack-based buffer overflow
+- add icu.8984.CVE-2011-4599.patch
+
 * Tue Mar 08 2011 Caolán McNamara <caolanm at redhat.com> - 4.6-2
 - Resolves: rhbz#681941 don't link unneccessary -lm, etc.