[kernel/f16] drm: try harder to fix bad edids
Ben Skeggs
bskeggs at fedoraproject.org
Fri Dec 16 04:09:30 UTC 2011
commit 9d2d81fc04489f16264db08c4d60426b3b509bd0
Author: Ben Skeggs <bskeggs at redhat.com>
Date: Fri Dec 16 14:11:46 2011 +1000
drm: try harder to fix bad edids
drm-edid-try-harder-to-fix-up-broken-headers.patch | 47 ++++++++++++++++++++
kernel.spec | 7 +++-
2 files changed, 53 insertions(+), 1 deletions(-)
---
diff --git a/drm-edid-try-harder-to-fix-up-broken-headers.patch b/drm-edid-try-harder-to-fix-up-broken-headers.patch
new file mode 100644
index 0000000..26660d7
--- /dev/null
+++ b/drm-edid-try-harder-to-fix-up-broken-headers.patch
@@ -0,0 +1,47 @@
+From 115cb7ab7d3b87fe43b1fe9b05ec894b1fcfb5cf Mon Sep 17 00:00:00 2001
+From: Adam Jackson <ajax at redhat.com>
+Date: Wed, 7 Dec 2011 18:26:23 -0500
+Subject: [PATCH] drm/edid: Try harder to fix up broken headers
+
+There's no reason to force the first byte to be correct if we're already
+scoring how correct the header is.
+
+See also: https://bugzilla.redhat.com/show_bug.cgi?id=722909
+
+Signed-off-by: Adam Jackson <ajax at redhat.com>
+---
+ drivers/gpu/drm/drm_edid.c | 18 ++++++++----------
+ 1 files changed, 8 insertions(+), 10 deletions(-)
+
+diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
+index 7425e5c..8b16a49 100644
+--- a/drivers/gpu/drm/drm_edid.c
++++ b/drivers/gpu/drm/drm_edid.c
+@@ -154,16 +154,14 @@ drm_edid_block_valid(u8 *raw_edid)
+ int i;
+ u8 csum = 0;
+ struct edid *edid = (struct edid *)raw_edid;
+-
+- if (raw_edid[0] == 0x00) {
+- int score = drm_edid_header_is_valid(raw_edid);
+- if (score == 8) ;
+- else if (score >= 6) {
+- DRM_DEBUG("Fixing EDID header, your hardware may be failing\n");
+- memcpy(raw_edid, edid_header, sizeof(edid_header));
+- } else {
+- goto bad;
+- }
++ int score = drm_edid_header_is_valid(raw_edid);
++
++ if (score == 8) ;
++ else if (score >= 6) {
++ DRM_DEBUG("Fixing EDID header, your hardware may be failing\n");
++ memcpy(raw_edid, edid_header, sizeof(edid_header));
++ } else {
++ goto bad;
+ }
+
+ for (i = 0; i < EDID_LENGTH; i++)
+--
+1.7.7.3
+
diff --git a/kernel.spec b/kernel.spec
index 9406cb8..49a317c 100644
--- a/kernel.spec
+++ b/kernel.spec
@@ -54,7 +54,7 @@ Summary: The Linux kernel
# For non-released -rc kernels, this will be appended after the rcX and
# gitX tags, so a 3 here would become part of release "0.rcX.gitX.3"
#
-%global baserelease 6
+%global baserelease 7
%global fedora_build %{baserelease}
# base_sublevel is the kernel version we're starting with and patching
@@ -697,6 +697,7 @@ Patch901: asus-laptop-3.2-backport.patch
Patch1500: fix_xen_guest_on_old_EC2.patch
# DRM
+Patch1700: drm-edid-try-harder-to-fix-up-broken-headers.patch
# nouveau + drm fixes
Patch1810: drm-nouveau-updates.patch
@@ -1382,6 +1383,7 @@ ApplyPatch linux-2.6-e1000-ich9-montevina.patch
ApplyPatch fix_xen_guest_on_old_EC2.patch
# DRM core
+ApplyPatch drm-edid-try-harder-to-fix-up-broken-headers.patch
# Nouveau DRM
ApplyOptionalPatch drm-nouveau-updates.patch
@@ -2214,6 +2216,9 @@ fi
# and build.
%changelog
+* Fri Dec 16 2011 Ben Skeggs <bskeggs at redhat.com> - 3.1.5-7
+- Add patch to do a better job of dealing with busted EDID headers (rhbz#751589)
+
* Thu Dec 15 2011 Josh Boyer <jwboyer at redhat.com> - 3.1.5-6
- Add patch to fix Intel wifi regression in 3.1.5 (rhbz 767173)
More information about the scm-commits
mailing list