[xinetd/f13/master] - fix crash when application's logfile hit size limit Related: #244063

Vojtěch Vítek vvitek at fedoraproject.org
Fri Feb 18 14:46:12 UTC 2011


commit 0021bc3a7115bca375ea21146bff6bca0493b77d
Author: Vojtech Vitek (V-Teq) <vvitek at redhat.com>
Date:   Fri Feb 18 15:43:09 2011 +0100

    - fix crash when application's logfile hit size limit
      Related: #244063

 xinetd-2.3.13-log-crash.patch |   17 +++++++++++++++++
 xinetd.spec                   |    5 +++++
 2 files changed, 22 insertions(+), 0 deletions(-)
---
diff --git a/xinetd-2.3.13-log-crash.patch b/xinetd-2.3.13-log-crash.patch
new file mode 100644
index 0000000..abd4d42
--- /dev/null
+++ b/xinetd-2.3.13-log-crash.patch
@@ -0,0 +1,17 @@
+244063: RHEL4 SIGSEGV in xinetd when application's logfile hit size limit
+
+Written-By: Jan Safranek <jsafrane at redhat.com>
+
+Initialize xl_callback_arg, so xinetd does not crash when it gets dereferenced.
+
+diff -up xinetd-2.3.13/libs/src/xlog/xlog.c.orig xinetd-2.3.13/libs/src/xlog/xlog.c
+--- xinetd-2.3.13/libs/src/xlog/xlog.c.orig	2003-05-31 23:58:58.000000000 +0200
++++ xinetd-2.3.13/libs/src/xlog/xlog.c	2007-12-05 15:31:08.000000000 +0100
+@@ -216,6 +216,7 @@ int xlog_control( xlog_h pxlog, xlog_cmd
+ 		
+ 		case XLOG_CALLBACK:
+ 			xp->xl_callback = va_arg( ap, voidfunc ) ;
++			xp->xl_callback_arg = va_arg( ap, void * );
+ 			break ;
+ 			
+ 		case XLOG_GETFLAG:
diff --git a/xinetd.spec b/xinetd.spec
index 308594c..283f7c0 100644
--- a/xinetd.spec
+++ b/xinetd.spec
@@ -39,6 +39,7 @@ Patch15: xinetd-2.3.14-ipv6confusion.patch
 # This fixes bug #593904 - online reconfiguration caused log message
 # flood when turning off UDP service
 Patch16: xinetd-2.3.14-udp-reconfig.patch
+Patch17: xinetd-2.3.13-log-crash.patch
 
 BuildRequires: autoconf, automake
 BuildRequires: libselinux-devel >= 1.30
@@ -83,6 +84,7 @@ located in the /etc/xinetd.d directory.
 %patch14 -p1 -b .clean-pfd
 %patch15 -p1 -b .ipv6confusion
 %patch16 -p1 -b .udp-reconfig
+%patch17 -p1 -b .log-crash
 
 aclocal
 autoconf
@@ -142,6 +144,9 @@ fi
 %{_mandir}/*/*
 
 %changelog
+- fix crash when application's logfile hit size limit
+  Related: #244063
+
 * Wed Jun 02 2010 Jan Zeleny <jzeleny at redhat.com> - 2:2.3.14-32
 - fixed log message flooding when turning off UDP service during online
   reconfiguration (#593904)


More information about the scm-commits mailing list