[libnotify] Unbreak firefox. (#654628)

Bill Nottingham notting at fedoraproject.org
Tue Jan 4 02:06:21 UTC 2011


commit 1277ea13908d0cf638320bc4f20b78098f3ff681
Author: Bill Nottingham <notting at redhat.com>
Date:   Mon Jan 3 21:05:54 2011 -0500

    Unbreak firefox. (#654628)

 ...fication_set_image_from_pixbuf-ref-the-pi.patch |   25 ++++++++++++++++++++
 libnotify.spec                                     |    7 ++++-
 2 files changed, 31 insertions(+), 1 deletions(-)
---
diff --git a/0001-notify_notification_set_image_from_pixbuf-ref-the-pi.patch b/0001-notify_notification_set_image_from_pixbuf-ref-the-pi.patch
new file mode 100644
index 0000000..0b677d9
--- /dev/null
+++ b/0001-notify_notification_set_image_from_pixbuf-ref-the-pi.patch
@@ -0,0 +1,25 @@
+From 49766bca28bb6fc57689f6061669bb44362d694d Mon Sep 17 00:00:00 2001
+From: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
+Date: Tue, 2 Nov 2010 17:02:37 +0100
+Subject: [PATCH] notify_notification_set_image_from_pixbuf: ref the pixbuf (#633829)
+
+---
+ libnotify/notification.c |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/libnotify/notification.c b/libnotify/notification.c
+index 2d5ecd9..571eff6 100644
+--- a/libnotify/notification.c
++++ b/libnotify/notification.c
+@@ -695,7 +695,7 @@ notify_notification_set_image_from_pixbuf (NotifyNotification *notification,
+                                                         image_len,
+                                                         TRUE,
+                                                         (GDestroyNotify) g_object_unref,
+-                                                        pixbuf));
++                                                        g_object_ref (pixbuf)));
+         notify_notification_set_hint (notification, hint_name, value);
+ }
+ 
+-- 
+1.7.1
+
diff --git a/libnotify.spec b/libnotify.spec
index 5d6dcf4..c1db7be 100644
--- a/libnotify.spec
+++ b/libnotify.spec
@@ -4,7 +4,7 @@
 Summary: Desktop notification library
 Name: libnotify
 Version: 0.7.0
-Release: 1%{?dist}
+Release: 2%{?dist}
 URL: http://library.gnome.org/devel/notification-spec/
 Source0: http://download.gnome.org/sources/%{name}/0.7/%{name}-%{version}.tar.bz2
 License: LGPLv2+
@@ -17,6 +17,7 @@ BuildRequires: dbus-devel >= %{dbus_version}
 BuildRequires: dbus-glib-devel >= %{dbus_glib_version}
 Requires: glib2 >= %{glib2_version}
 Requires: desktop-notification-daemon
+Patch0: 0001-notify_notification_set_image_from_pixbuf-ref-the-pi.patch
 
 %description
 libnotify is a library for sending desktop notifications to a notification
@@ -39,6 +40,7 @@ development of programs using %{name}.
 
 %prep
 %setup -q
+%patch0 -p1
 
 %build
 %configure
@@ -71,6 +73,9 @@ rm -f $RPM_BUILD_ROOT%{_libdir}/*.a
 %{_datadir}/gtk-doc/html/libnotify/*
 
 %changelog
+* Mon Jan  3 2011 Bill Nottingham <notting at redhat.com> - 0.7.0-2
+- unbreak firefox and similar apps that free pixbufs they send to set_image_from_pixbuf (#654628)
+
 * Mon Nov  1 2010 Matthias Clasen <mclasen at redhat.com> - 0.7.0-1
 - Update to 0.7.0
 


More information about the scm-commits mailing list