[python-nss] - Fix all rpmlint warnings - doc for license, changelog etc. now in main package, doc subpackage n

John Dennis jdennis at fedoraproject.org
Tue Jan 11 19:04:32 UTC 2011


commit 149c6b6a74fb9ea580416d3dc771b71eee365dc8
Author: John Dennis <jdennis at redhat.com>
Date:   Tue Jan 11 14:03:59 2011 -0500

    - Fix all rpmlint warnings
    - doc for license, changelog etc. now in main package,
      doc subpackage now only contains api doc, examples, test, etc.
    - Filter provides for .so files
    - Remove execute permission on everything in docdir
    - Capitalize description

 python-nss.spec |   35 +++++++++++++++++++++++++++++------
 1 files changed, 29 insertions(+), 6 deletions(-)
---
diff --git a/python-nss.spec b/python-nss.spec
index 8b819c4..33dcd0f 100644
--- a/python-nss.spec
+++ b/python-nss.spec
@@ -6,7 +6,7 @@
 
 Name:           python-nss
 Version:        0.10
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        Python bindings for Network Security Services (NSS)
 
 Group:          Development/Languages
@@ -17,6 +17,12 @@ BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 %global docdir %{_docdir}/%{name}-%{version}
 
+# We don't want to provide private python extension libs
+%{?filter_setup:
+%filter_provides_in %{python_sitearch}/.*\.so$ 
+%filter_setup
+}
+
 BuildRequires: python-devel
 BuildRequires: python-setuptools-devel
 BuildRequires: python-docutils
@@ -36,11 +42,11 @@ implementations have been FIPS-140 certified.
 
 %package doc
 Group: Documentation
-Summary: python-nss API documentation and examples
+Summary: API documentation and examples
 Requires: %{name} = %{version}-%{release}
 
 %description doc
-python-nss API documentation and examples
+API documentation and examples
 
 %prep
 %setup -q
@@ -57,8 +63,8 @@ rm -rf $RPM_BUILD_ROOT
 %{__python} setup.py install  -O1 --install-platlib %{python_sitearch} --skip-build --root $RPM_BUILD_ROOT
 %{__python} setup.py install_doc --docdir %{docdir} --skip-build --root $RPM_BUILD_ROOT
 
-# Remove execution permission from any example scripts
-find $RPM_BUILD_ROOT/%{docdir}/examples -type f | xargs chmod a-x
+# Remove execution permission from any example/test files in docdir
+find $RPM_BUILD_ROOT/%{docdir} -type f | xargs chmod a-x
 
 # Set correct permissions on .so files
 chmod 0755 $RPM_BUILD_ROOT/%{python_sitearch}/nss/*.so
@@ -71,12 +77,29 @@ rm -rf $RPM_BUILD_ROOT
 %files
 %defattr(-,root,root,-)
 %{python_sitearch}/*
+%doc %{docdir}/ChangeLog
+%doc %{docdir}/LICENSE.gpl
+%doc %{docdir}/LICENSE.lgpl
+%doc %{docdir}/LICENSE.mpl
+%doc %{docdir}/README
 
 %files doc
 %defattr(-,root,root,-)
-%doc %{docdir}
+%doc %{docdir}/examples
+%doc %{docdir}/test
+%if %build_api_doc
+%doc %{docdir}/api
+%endif
 
 %changelog
+* Tue Jan 11 2011 John Dennis <jdennis at redhat.com> - 0.10-3
+- Fix all rpmlint warnings
+- doc for license, changelog etc. now in main package,
+  doc subpackage now only contains api doc, examples, test, etc.
+- Filter provides for .so files
+- Remove execute permission on everything in docdir
+- Capitalize description
+
 * Tue Jan 11 2011 John Dennis <jdennis at redhat.com> - 0.10-2
 - split documentation out into separate doc sub-package
   and make building api documentation optional


More information about the scm-commits mailing list