[cppad] Change where pkgconfig/cppad.pc is installed from %{_libdir} to %{_datadir}

Bradley M. Bell bradbell at fedoraproject.org
Tue Jan 18 15:13:35 UTC 2011


commit 0ee1e154c7d9161fb060752506fe8ec0382c34ca
Author: Brad Bell <bradbell at seanet.com>
Date:   Tue Jan 18 07:10:19 2011 -0800

    Change  where pkgconfig/cppad.pc is installed from %{_libdir} to %{_datadir}

 cppad.spec |   56 ++++++++++++++++++++++++++++++++++++--------------------
 1 files changed, 36 insertions(+), 20 deletions(-)
---
diff --git a/cppad.spec b/cppad.spec
index 5860625..7873ef3 100644
--- a/cppad.spec
+++ b/cppad.spec
@@ -1,19 +1,26 @@
-# Known Problems: 
+# Known rpmlint warnings: 
 #
-# After installation of cppad-doc-%{version} the command
-#     rpmlint cppad-doc
-# results in the following error message 
-#     W: file-not-utf8 /usr/share/doc/cppad-%{version}/pmathmlcss.xsl
+# cppad.spec: spelling-error Sumary(en_US) devel:
+# Although not in the en_US dictionary, 'devel' is understood by Fedora users.
+#
+# cppad.spec: rpm-buildroot-usage: 
+# RPM_BUILD_ROOT is used to test includes from installed directory.
+#
+# cppad-20110101.2.gpl.tgz: strange-permission 0444L
+# The premissions are for readonly, which seems fine in this case.
+# 
+# %{_docdir}/%{name}-%{version}/pmathmlcss.xsl: file-not-utf8:
 # The file pmathmlcss.xsl is the standard presentation MathML style sheet.
 # Except for white space and a comment at the top, it is identical to
 #     http://www.w3.org/Math/XSL/pmathmlcss.xsl
 # (use wget and diff -b to see that this is true).
+#
 # ---------------------------------------------------------------------------- 
 
 Name: cppad
 Version: 20110101.2
-Release: 1%{?dist}
-Summary: No base package is installed, see %{name}-devel 
+Release: 2%{?dist}
+Summary: C++ Algorithmic Differentiation (AD), %{name}-devel and %{name}-doc.
 
 Group: Development/Libraries 
 License: GPLv2
@@ -23,11 +30,11 @@ BuildArch: noarch
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 %description
-There is no base %{name} package installation, only %{name}-devel is installed.
+C++ Algorithmic Differentiation (AD), see %{name}-devel, %{name}-doc.
 
 # ---------------------------------------------------------------------------
 %package devel
-Summary: Development libraries for %{name}
+Summary: The %{name} C++ include files for Algorithmic Differentiation (AD)
 Group: Development/Libraries
 Provides: %{name} = %{version}-%{release}
 
@@ -38,21 +45,22 @@ Algorithmic Differentiation (often referred to as Automatic Differentiation.)
 Given a C++ algorithm that computes function values, %{name} generates an 
 algorithm that computes its derivative values. A brief introduction to 
 Algorithmic Differentiation (AD) can be found at 
-http://en.wikipedia.org/wiki/Automatic_differentiation
+	http://en.wikipedia.org/wiki/Automatic_differentiation
+See the package %{name}-doc for documentation of this version of %{name}. 
 
 # ----------------------------------------------------------------------------
 %package doc
 Summary: Documentation for %{name}
-Group: Development/Libraries
+Group: XML documentation for %{name}-devel 
 
 %description doc
-The %{name}-doc package contains the xml documentation for
-the %{name}-devel package. 
-Links to an html version of the %{name} documentaiton, 
-for the most recent version of %{name}, can be found at web site 
-http://www.coin-or.org/CppAD/.
-In addition, printable versions of the documentation
-as a single web page, in both html and xml, can be found at that web site.
+The %{name}-doc package installs the XML documentation for %{name}-devel in
+	%{_docdir}/%{name}-%{version}
+Links to an HTML version of the %{name} documentation, for the most recent 
+version of %{name}, can be found at the web site 
+	http://www.coin-or.org/CppAD/
+In addition, printable versions of the documentation,
+as a single web page, in both HTML and XML, can be found at that web site.
 
 # ----------------------------------------------------------------------------
 %prep
@@ -67,7 +75,8 @@ do
 	if ! (echo $file | grep 'speed/src/makefile.in' > /dev/null)
 	then
 		sed -i "$file" \
-		-e "s|-I\$(top_srcdir)\([^/]\)|-I$RPM_BUILD_ROOT/usr/include\1|"
+		-e "s|-I\$(top_srcdir)\([^/]\)|-I$RPM_BUILD_ROOT/usr/include\1|" \
+		-e 's|^pkgconfigdir *=.*|pkgconfigdir = $(datadir)/pkgconfig|'
 	fi
 done
 
@@ -109,7 +118,7 @@ rm -rf $RPM_BUILD_ROOT
 %defattr(-,root,root,-)
 %doc COPYING ChangeLog AUTHORS uw_copy_040507.html
 %{_includedir}/%{name}
-%{_libdir}/pkgconfig/%{name}.pc
+%{_datadir}/pkgconfig/%{name}.pc
 
 %files doc
 %defattr(-,root,root,-)
@@ -117,6 +126,13 @@ rm -rf $RPM_BUILD_ROOT
 
 # ----------------------------------------------------------------------------
 %changelog
+* Tue Jan 18 2011 Brad Bell <bradbell at seanet dot com> - 20110101.2-2
+- Fix rpmlint error, libdir-macro-in-noarch-package by moving the pkg-config 
+- file cppad.pc from %%_libdir to %%_datadir.
+- Improve the %%Summary and %%description entries.
+- Fix some rpmlint spelling warnings including xml -> XML, html -> HTML. 
+- Document (at top of spec file) reason for other warnings that are not fixed.
+
 * Mon Jan 17 2011 Brad Bell <bradbell at seanet dot com> - 20110101.2-1 
 - The fedora source 20110101.0 has the worng check sum, get new upstream source.
 - Remove sed patches for problems that were fixed in upstream source.


More information about the scm-commits mailing list