[rsyslog/f15] Combine triggers to properly handle upgrade (#699198)

Bill Nottingham notting at fedoraproject.org
Mon May 16 19:41:34 UTC 2011


commit 0dcc29e67ee9fe56e9511fed1cbd325890409c44
Author: Bill Nottingham <notting at redhat.com>
Date:   Mon May 16 15:40:16 2011 -0400

    Combine triggers to properly handle upgrade (#699198)
    
    From https://bugzilla.redhat.com/show_bug.cgi?id=702378#c2:
    
    This is the intended and expected behavior (from rpm POV): only a single
    trigger is executed per each trigger target <-> source pair in a transaction.
    
    By combining them, the right thing should happen.

 rsyslog.spec |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)
---
diff --git a/rsyslog.spec b/rsyslog.spec
index b5102d3..976e6f4 100644
--- a/rsyslog.spec
+++ b/rsyslog.spec
@@ -6,7 +6,7 @@
 Summary: Enhanced system logging and kernel message trapping daemon
 Name: rsyslog
 Version: 5.7.9
-Release: 2%{?dist}
+Release: 3%{?dist}
 License: GPLv3+
 Group: System Environment/Daemons
 URL: http://www.rsyslog.com/
@@ -208,18 +208,15 @@ if [ $1 -ge 1 ] ; then
         /bin/systemctl try-restart rsyslog.service >/dev/null 2>&1 || :
 fi
 
-%triggerun -- rsyslog < 3.0.0
-/bin/kill `cat /var/run/rklogd.pid 2> /dev/null` > /dev/null 2>&1 ||:
-
-%triggerun -- rsyslog < 5.6.2
-# previous versions used a different lock file, which would break condrestart
-[ -f /var/lock/subsys/rsyslogd ] || exit 0
-mv /var/lock/subsys/rsyslogd /var/lock/subsys/rsyslog
-
 %triggerun -- rsyslog < 5.7.8-1
 if /sbin/chkconfig --level 3 rsyslog ; then
         /bin/systemctl --no-reload enable rsyslog.service >/dev/null 2>&1 || :
 fi
+# previous versions used a different lock file, which would break condrestart
+[ -f /var/lock/subsys/rsyslogd ] || exit 0
+mv /var/lock/subsys/rsyslogd /var/lock/subsys/rsyslog
+[ -f /var/run/rklogd.pid ] || exit 0
+/bin/kill `cat /var/run/rklogd.pid 2> /dev/null` > /dev/null 2>&1 ||:
 
 %files
 %defattr(-,root,root,-)
@@ -295,6 +292,9 @@ fi
 %{_libdir}/rsyslog/omudpspoof.so
 
 %changelog
+* Mon May 16 2011 Bill Nottingham <notting at redhat.com> - 5.7.9-3
+- combine triggers (as rpm will only execute one) - fixes upgrades (#699198)
+
 * Wed Mar 23 2011 Dan Horák <dan at danny.cz> - 5.7.9-2
 - rebuilt for mysql 5.5.10 (soname bump in libmysqlclient)
 


More information about the scm-commits mailing list