[tree] Fixed memory leak spotted by coverity (bug #704570).

Tim Waugh twaugh at fedoraproject.org
Fri May 20 15:14:29 UTC 2011


commit ed5c7d27f30cfb84023b256a8cbf0f3031dbd65a
Author: Tim Waugh <twaugh at redhat.com>
Date:   Fri May 20 16:14:09 2011 +0100

    Fixed memory leak spotted by coverity (bug #704570).

 tree-coverity-resource-leak.patch |   11 +++++++++++
 tree.spec                         |    9 ++++++++-
 2 files changed, 19 insertions(+), 1 deletions(-)
---
diff --git a/tree-coverity-resource-leak.patch b/tree-coverity-resource-leak.patch
new file mode 100644
index 0000000..5444844
--- /dev/null
+++ b/tree-coverity-resource-leak.patch
@@ -0,0 +1,11 @@
+diff -up tree-1.5.3/tree.c.coverity-resource-leak tree-1.5.3/tree.c
+--- tree-1.5.3/tree.c.coverity-resource-leak	2011-05-20 16:10:43.802104336 +0100
++++ tree-1.5.3/tree.c	2011-05-20 16:11:36.922059759 +0100
+@@ -642,6 +642,7 @@ void listdir(char *d, int *dt, int *ft, 
+ 
+   if ((Level >= 0) && (lev > Level)) {
+     if (!Hflag) fprintf(outfile,"\n");
++    free(path);
+     return;
+   }
+ 
diff --git a/tree.spec b/tree.spec
index bf083f7..92d2c5b 100644
--- a/tree.spec
+++ b/tree.spec
@@ -1,7 +1,7 @@
 Summary: File system tree viewer
 Name: tree
 Version: 1.5.3
-Release: 3%{?dist}
+Release: 4%{?dist}
 Group: Applications/File
 License: GPLv2+
 Url: http://mama.indstate.edu/users/ice/tree/
@@ -10,6 +10,7 @@ Patch1: tree-1.2-carrot.patch
 Patch2: tree-1.2-no-strip.patch
 Patch3: tree-preserve-timestamps.patch
 Patch4: tree-no-color-by-default.patch
+Patch5: tree-coverity-resource-leak.patch
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 %description
@@ -31,6 +32,9 @@ utility.
 # Disable color output by default.
 %patch4 -p1 -b .no-color-by-default
 
+# Fixed memory leak spotted by coverity (bug #704570).
+%patch5 -p1 -b .coverity-resource-leak
+
 %build
 make CFLAGS="$RPM_OPT_FLAGS" "CPPFLAGS=$(getconf LFS_CFLAGS)" %{?_smp_mflags}
 
@@ -54,6 +58,9 @@ rm -rf $RPM_BUILD_ROOT
 %doc README LICENSE
 
 %changelog
+* Fri May 20 2011 Tim Waugh <twaugh at redhat.com> 1.5.3-4
+- Fixed memory leak spotted by coverity (bug #704570).
+
 * Wed Feb 09 2011 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.5.3-3
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 


More information about the scm-commits mailing list