[gstreamer-plugins-good] Add flac sample number rounding patch

Brian Pepple bpepple at fedoraproject.org
Sun Nov 27 22:43:25 UTC 2011


commit 42f9305aee4344b4ab34463bf92234a6460b3282
Author: Brian Pepple <bpepple at fedoraproject.org>
Date:   Sun Nov 27 17:42:25 2011 -0500

    Add flac sample number rounding patch

 ...30-flacdec_correct_sample_number_rounding.patch |   24 ++++++++++++++++++++
 1 files changed, 24 insertions(+), 0 deletions(-)
---
diff --git a/gstreamer-plugins-good-0.10.30-flacdec_correct_sample_number_rounding.patch b/gstreamer-plugins-good-0.10.30-flacdec_correct_sample_number_rounding.patch
new file mode 100644
index 0000000..dac7147
--- /dev/null
+++ b/gstreamer-plugins-good-0.10.30-flacdec_correct_sample_number_rounding.patch
@@ -0,0 +1,24 @@
+From 799c8e3d04456ce0b22c03de66d20d0a1a599643 Mon Sep 17 00:00:00 2001
+From: Monty Montgomery <cmontgom at redhat.com>
+Date: Thu, 21 Jul 2011 21:23:28 +0000
+Subject: flacdec: Correct sample number rounding resulting in timestamp jitter
+
+flacdec converts the src timestamp to a sample number, uses that internally, then reconverts the sample number to a timestamp for the output buffer.  Unfortunately, sample numbers can't be represented in an integer number of nanoseconds, and the conversion process was truncating rather than rounding, resulting in sample numbers and output timestamps that were often off by a full sample.
+
+This corrects the time->sample convesion
+---
+diff --git a/ext/flac/gstflacdec.c b/ext/flac/gstflacdec.c
+index 061fa81..1e2ef5e 100644
+--- a/ext/flac/gstflacdec.c
++++ b/ext/flac/gstflacdec.c
+@@ -1668,7 +1668,7 @@ gst_flac_dec_convert_src (GstPad * pad, GstFormat src_format, gint64 src_value,
+         case GST_FORMAT_BYTES:
+           scale = bytes_per_sample;
+         case GST_FORMAT_DEFAULT:
+-          *dest_value = gst_util_uint64_scale_int (src_value,
++          *dest_value = gst_util_uint64_scale_int_round (src_value,
+               scale * flacdec->sample_rate, GST_SECOND);
+           break;
+         default:
+--
+cgit v0.9.0.2-2-gbebe


More information about the scm-commits mailing list