[apper] hack around crash on installing standalone rpms

Rex Dieter rdieter at fedoraproject.org
Wed Oct 19 18:28:12 UTC 2011


commit a734d87a0fc3a974022a6bba9c14264457f9181c
Author: Rex Dieter <rdieter at fedoraproject.org>
Date:   Wed Oct 19 13:35:35 2011 -0500

    hack around crash on installing standalone rpms

 apper-0.7.0-crashfix.patch |   27 +++++++++++++++++++++++++++
 apper.spec                 |    8 +++++++-
 2 files changed, 34 insertions(+), 1 deletions(-)
---
diff --git a/apper-0.7.0-crashfix.patch b/apper-0.7.0-crashfix.patch
new file mode 100644
index 0000000..98d2b96
--- /dev/null
+++ b/apper-0.7.0-crashfix.patch
@@ -0,0 +1,27 @@
+diff -up apper-0.7.0/libapper/Requirements.cpp.crashfix apper-0.7.0/libapper/Requirements.cpp
+--- apper-0.7.0/libapper/Requirements.cpp.crashfix	2011-10-10 10:34:18.000000000 -0500
++++ apper-0.7.0/libapper/Requirements.cpp	2011-10-19 13:32:12.191857593 -0500
+@@ -149,7 +149,9 @@ Requirements::~Requirements()
+     KConfigGroup requirementsDialog(&config, "requirementsDialog");
+     saveDialogSize(requirementsDialog);
+ 
+-    if (!m_hideAutoConfirm) {
++    // isChecked is crashing mysteriously (use after free somewhere?),
++    // maybe hack all this out for now -- rex
++    if (0 && !m_hideAutoConfirm) {
+         requirementsDialog.writeEntry("autoConfirm", ui->confirmCB->isChecked());
+     }
+     config.sync();
+diff -up apper-0.7.0/libapper/Requirements.ui.crashfix apper-0.7.0/libapper/Requirements.ui
+--- apper-0.7.0/libapper/Requirements.ui.crashfix	2011-10-10 10:34:18.000000000 -0500
++++ apper-0.7.0/libapper/Requirements.ui	2011-10-19 13:32:02.285981435 -0500
+@@ -83,6 +83,9 @@
+    </item>
+    <item row="2" column="0" colspan="2">
+     <widget class="QCheckBox" name="confirmCB">
++     <property name="enabled">
++      <bool>false</bool>
++     </property>
+      <property name="text">
+       <string>Do not confirm when installing or updating additional packages</string>
+      </property>
diff --git a/apper.spec b/apper.spec
index 34f7649..c1e21c1 100644
--- a/apper.spec
+++ b/apper.spec
@@ -5,7 +5,7 @@
 
 Name:    apper
 Version: 0.7.0
-Release: 4%{?dist}
+Release: 5%{?dist}
 Summary: KDE interface for PackageKit
 
 License: GPLv2+
@@ -19,6 +19,8 @@ Patch1: apper-0.7.0-systray_actions.patch
 ## upstreamable patches
 # fix Exec, Categories
 Patch50: apper-0.7.0-dt_categories.patch
+# hack around crash in standalone installs
+Patch51: apper-0.7.0-crashfix.patch
 
 ## upstream patches
 
@@ -49,6 +51,7 @@ KDE interface for PackageKit.
 
 %patch1 -p1 -b .systray_actions
 %patch50 -p1 -b .dt_categories
+%patch51 -p1 -b .crashfix
 
 
 %build
@@ -104,6 +107,9 @@ desktop-file-validate %{buildroot}%{_kde4_datadir}/applications/kde4/apper.deskt
 
 
 %changelog
+* Wed Oct 19 2011 Rex Dieter <rdieter at fedoraproject.org> 0.7.0-5
+- hack around crash on installing standalone rpms
+
 * Wed Oct 19 2011 Rex Dieter <rdieter at fedoraproject.org> 0.7.0-4
 - systray_actions patch/hack
 


More information about the scm-commits mailing list