[ElectricFence] Add comments explaining points raised by the reviewer

Petr Machata pmachata at fedoraproject.org
Fri Apr 27 15:37:29 UTC 2012


commit cc83ad8deed38385c6ec48b9ad98e0e964b05c99
Author: Petr Machata <pmachata at redhat.com>
Date:   Fri Apr 27 17:37:11 2012 +0200

    Add comments explaining points raised by the reviewer

 ElectricFence.spec |   20 +++++++++++++++++++-
 1 files changed, 19 insertions(+), 1 deletions(-)
---
diff --git a/ElectricFence.spec b/ElectricFence.spec
index 54f95ea..af5048c 100644
--- a/ElectricFence.spec
+++ b/ElectricFence.spec
@@ -1,3 +1,18 @@
+# Regarding the following rpmlint citation:
+#
+#   library package calls exit() or _exit() [...]
+#
+# Electric fence is a debugger, not a library.  The fact that it comes
+# in the form factor of a library is just because that's how you
+# override malloc-related calls from libc.  Calling _exit is the
+# ultimate outcome of detecting a class of memory errors (double free,
+# free of wild pointer, etc.)  Overflows (or underflows) are detected
+# by the operating system and lead to process termination as well.
+#
+#   devel-file-in-non-devel-package /usr/lib64/libefence.a
+#
+# Electric fence is itself a development package.
+
 Summary: A debugger which detects memory allocation violations
 Name: ElectricFence
 Version: 2.2.2
@@ -7,7 +22,10 @@ Group: Development/Tools
 URL: http://perens.com/FreeSoftware/ElectricFence/
 
 # ftp://ftp.perens.com/pub/ElectricFence/beta/ used to be here, but
-# the site is inaccessible as of lately
+# the site is inaccessible as of lately.  I looked through the web but
+# didn't find anything.  Debian has a link to a site that hosts an
+# obsolete version.  I don't think there's any proper upstream for
+# this.
 Source: %{name}-%{version}.tar.gz
 Patch1: ElectricFence-2.0.5-longjmp.patch
 Patch2: ElectricFence-2.1-vaarg.patch


More information about the scm-commits mailing list