[kexec-tools] Take closing the reboot dialog as no

Dave Young yangrr at fedoraproject.org
Thu Aug 9 02:48:27 UTC 2012


commit 2b11d78e2e70815b8fb97ba9ad0537f9b903bb5d
Author: Dave Young <dyoung at redhat.com>
Date:   Thu Aug 9 10:22:50 2012 +0800

    Take closing the reboot dialog as no
    
    Resolves: bz805782
    
    Copying something from old bug 688150:
    Steps to Reproduce:
    1.Go through FirstBoot process while get to Kdump
    2.Change Kdump memory
    3.Press Finish
    4.A window pops-up (Changing Kdump setting requires ...)
    5.Do not press "No" or "Yes" but pres the "X"  in the right up corner.
    
    Actual results:
    The effect of this action is the same as pressing "YES"
    
    Expected results:
    The effect of this action is the same as pressing "NO
    
    So this patch fix to only reboot when rc == gtk.RESPONSE_YES.
    
    Port from below patch from rhel:
    commit ed0c89d8e42b9205671cb6c81f9f73c275bee72f
    Author: amwang <amwang at redhat.com>
    Date:   Thu Mar 17 10:07:52 2011 +0000
    
        Resolves: bug 688150.
    
    Signed-off-by: Dave Young <dyoung at redhat.com>
    Acked-by: Vivek Goyal <vgoyal at redhat.com>

 firstboot_kdump.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/firstboot_kdump.py b/firstboot_kdump.py
index 7aec3cd..59c6709 100755
--- a/firstboot_kdump.py
+++ b/firstboot_kdump.py
@@ -375,7 +375,7 @@ class moduleClass(Module):
 			rc = dlg.run()
 			dlg.destroy()
 
-			if rc == gtk.RESPONSE_NO:
+			if rc != gtk.RESPONSE_YES:
 				self.reboot = False
 				return RESULT_SUCCESS 
 			else:


More information about the scm-commits mailing list