[fetchmail] Fix issues found by fedora-review utility in the spec file

vcrhonek vcrhonek at fedoraproject.org
Mon Aug 27 13:40:12 UTC 2012


commit b3be25798a293e7a2aabafa53db8e59ca2e4bef4
Author: Vitezslav Crhonek <vcrhonek at redhat.com>
Date:   Mon Aug 27 15:39:02 2012 +0200

    Fix issues found by fedora-review utility in the spec file

 fetchmail.spec |   13 +++++--------
 1 files changed, 5 insertions(+), 8 deletions(-)
---
diff --git a/fetchmail.spec b/fetchmail.spec
index 51df663..3fb383b 100644
--- a/fetchmail.spec
+++ b/fetchmail.spec
@@ -1,16 +1,15 @@
-%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}
+%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")}
 
 Summary: A remote mail retrieval and forwarding utility
 Name: fetchmail
 Version: 6.3.21
-Release: 4%{?dist}
+Release: 5%{?dist}
 Source0: http://download.berlios.de/fetchmail/fetchmail-%{version}.tar.xz
 Source1: http://download.berlios.de/fetchmail/fetchmail-%{version}.tar.xz.asc
 URL: http://fetchmail.berlios.de/
 # For a breakdown of the licensing, see COPYING
 License: GPL+ and Public Domain
 Group: Applications/Internet
-Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires: gettext-devel hesiod-devel krb5-devel openssl-devel
 
 %description
@@ -35,7 +34,6 @@ connections.
 make
 
 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
 
 # remove fetchmailconf stuff
@@ -45,16 +43,15 @@ rm -f $RPM_BUILD_ROOT%{python_sitelib}/fetchmailconf.py*
 
 %find_lang %name
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %files -f %{name}.lang
-%defattr(-,root,root)
 %doc COPYING FAQ FEATURES NEWS NOTES README README.SSL TODO
 %{_bindir}/fetchmail
 %{_mandir}/man1/fetchmail.1*
 
 %changelog
+* Mon Aug 27 2012 Vitezslav Crhonek <vcrhonek at redhat.com> - 6.3.21-5
+- Fix issues found by fedora-review utility in the spec file
+
 * Thu Jul 19 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 6.3.21-4
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list