[kbd] Fix issues found by fedora-review utility in the spec file

vcrhonek vcrhonek at fedoraproject.org
Tue Aug 28 11:19:36 UTC 2012


commit c2d2db324128e144afb0528c6913c735686a8dcc
Author: Vitezslav Crhonek <vcrhonek at redhat.com>
Date:   Tue Aug 28 13:12:53 2012 +0200

    Fix issues found by fedora-review utility in the spec file

 kbd.spec |   13 ++++---------
 1 files changed, 4 insertions(+), 9 deletions(-)
---
diff --git a/kbd.spec b/kbd.spec
index a3f71be..dc1a769 100644
--- a/kbd.spec
+++ b/kbd.spec
@@ -1,6 +1,6 @@
 Name:           kbd
 Version:        1.15.3
-Release:        6%{?dist}
+Release:        7%{?dist}
 Summary:        Tools for configuring the console (keyboard, virtual terminals, etc.)
 
 Group:          System Environment/Base
@@ -12,7 +12,6 @@ Source2:        kbd-latsun-fonts.tar.bz2
 Source3:        kbd-latarcyrheb-16-fixed.tar.bz2
 Source4:        fr-dvorak.tar.bz2
 Source5:        kbd-latarcyrheb-32.tar.bz2
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 # Patch0: puts additional information into man pages
 Patch0:         kbd-1.15-keycodes-man.patch
 # Patch1: sparc modifications
@@ -31,7 +30,6 @@ Patch6:         kbd-1.15.3-dumpkeys-man.patch
 Patch7:         kbd-1.15.3-loadkeys-d.patch 
 
 BuildRequires:  bison, flex, gettext
-Conflicts:      util-linux < 2.11r-9
 Requires:       initscripts >= 5.86-1
 Requires:       %{name}-misc = %{version}-%{release}
 
@@ -93,7 +91,6 @@ mv "ChangeLog_" "ChangeLog"
 make %{?_smp_mflags}
 
 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
 
 # ro_win.map.gz is useless
@@ -125,21 +122,19 @@ rm -rf $RPM_BUILD_ROOT/lib/kbd/locale
 
 %find_lang %{name}
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %files -f %{name}.lang
-%defattr(-,root,root,-)
 %doc ChangeLog AUTHORS README COPYING doc/kbd.FAQ*.html doc/font-formats/*.html doc/utf/utf* doc/dvorak/*
 /bin/*
 %{_bindir}/*
 %{_mandir}/*/*
 
 %files misc
-%defattr(-,root,root,-)
 /lib/kbd
 
 %changelog
+* Tue Aug 28 2012 Vitezslav Crhonek <vcrhonek at redhat.com> - 1.15.3-7
+- Fix issues found by fedora-review utility in the spec file
+
 * Thu Jul 19 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.15.3-6
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list