[libedit/f18] fix specfile issues reported by the fedora-review script

Kamil Dudka kdudka at fedoraproject.org
Tue Aug 28 14:46:26 UTC 2012


commit 769303c8dbf0db906434ca7f12226f7aa9eee4f3
Author: Kamil Dudka <kdudka at redhat.com>
Date:   Tue Aug 28 16:41:35 2012 +0200

    fix specfile issues reported by the fedora-review script

 libedit.spec |   14 +++++---------
 1 files changed, 5 insertions(+), 9 deletions(-)
---
diff --git a/libedit.spec b/libedit.spec
index 425157a..dfff946 100644
--- a/libedit.spec
+++ b/libedit.spec
@@ -1,9 +1,9 @@
-%define snap 20120601
+%global snap 20120601
 
 Summary:	The NetBSD Editline library
 Name:		libedit
 Version:	3.0
-Release:	7.%{snap}cvs%{?dist}
+Release:	8.%{snap}cvs%{?dist}
 License:	BSD
 Group:		System Environment/Libraries
 URL:		http://www.thrysoee.dk/editline/
@@ -48,25 +48,18 @@ sed -i "s/lcurses/ltinfo/" src/Makefile
 make %{?_smp_mflags}
 
 %install
-rm -rf $RPM_BUILD_ROOT
-
 make install INSTALL="%{__install} -p" DESTDIR=$RPM_BUILD_ROOT
 find $RPM_BUILD_ROOT -type f -name "*.la" -delete
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %post -p /sbin/ldconfig
 
 %postun -p /sbin/ldconfig
 
 %files
-%defattr(-,root,root,-)
 %doc ChangeLog COPYING THANKS
 %{_libdir}/%{name}.so.*
 
 %files devel
-%defattr(-,root,root,-)
 %doc examples/fileman.c examples/tc1.c examples/wtc1.c
 %doc %{_mandir}/man3/*
 %doc %{_mandir}/man5/editrc.5*
@@ -78,6 +71,9 @@ rm -rf $RPM_BUILD_ROOT
 %{_includedir}/editline/readline.h
 
 %changelog
+* Tue Aug 28 2012 Kamil Dudka <kdudka at redhat.com> - 3.0-8.20110802cvs
+- fix specfile issues reported by the fedora-review script
+
 * Wed Jul 18 2012 Kamil Dudka <kdudka at redhat.com> 3.0-7.20120601cvs
 - Update to 3.0 (20120601 snap)
 - fix crash of el_insertstr() on incomplete multi-byte sequence (#840598)


More information about the scm-commits mailing list