[libtar] fix specfile issues reported by the fedora-review script

Kamil Dudka kdudka at fedoraproject.org
Tue Aug 28 15:04:19 UTC 2012


commit ff1bbc872157cec57a96396e4f03f06664600825
Author: Kamil Dudka <kdudka at redhat.com>
Date:   Tue Aug 28 17:01:45 2012 +0200

    fix specfile issues reported by the fedora-review script

 libtar.spec |   14 +++++---------
 1 files changed, 5 insertions(+), 9 deletions(-)
---
diff --git a/libtar.spec b/libtar.spec
index abc5622..222bb33 100644
--- a/libtar.spec
+++ b/libtar.spec
@@ -1,7 +1,7 @@
 Summary:        Tar file manipulation API
 Name:           libtar
 Version:        1.2.11
-Release:        23%{?dist}
+Release:        24%{?dist}
 License:        MIT
 Group:          System Environment/Libraries
 URL:            http://www.feep.net/libtar/
@@ -43,7 +43,7 @@ developing applications that use %{name}.
 %patch6 -p1
 
 # set correct version for .so build
-%define ltversion %(echo %{version} | tr '.' ':')
+%global ltversion %(echo %{version} | tr '.' ':')
 sed -i 's/-rpath $(libdir)/-rpath $(libdir) -version-number %{ltversion}/' \
   lib/Makefile.in
 # sanitize the macro definitions so that aclocal can find them:
@@ -64,29 +64,22 @@ make %{?_smp_mflags}
 
 
 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
 # Without this we get no debuginfo and stripping
 chmod +x $RPM_BUILD_ROOT%{_libdir}/libtar.so.%{version}
 rm $RPM_BUILD_ROOT%{_libdir}/*.la
 
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
-
 %post -p /sbin/ldconfig
 %postun -p /sbin/ldconfig
 
 
 %files
-%defattr(-,root,root,-)
 %doc COPYRIGHT TODO README ChangeLog*
 %{_bindir}/%{name}
 %{_libdir}/lib*.so.*
 
 %files devel
-%defattr(-,root,root,-)
 %{_includedir}/libtar.h
 %{_includedir}/libtar_listhash.h
 %{_libdir}/lib*.so
@@ -94,6 +87,9 @@ rm -rf $RPM_BUILD_ROOT
 
 
 %changelog
+* Tue Aug 28 2012 Kamil Dudka <kdudka at redhat.com> - 1.2.11-24
+- fix specfile issues reported by the fedora-review script
+
 * Thu Jul 19 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.2.11-23
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list