[nano/f18] fix specfile issues reported by the fedora-review script

Kamil Dudka kdudka at fedoraproject.org
Tue Aug 28 15:38:39 UTC 2012


commit 2faaefbc494bf527cdfa1d3ab827e7b00085be60
Author: Kamil Dudka <kdudka at redhat.com>
Date:   Tue Aug 28 17:34:18 2012 +0200

    fix specfile issues reported by the fedora-review script

 nano.spec |   14 ++++++--------
 1 files changed, 6 insertions(+), 8 deletions(-)
---
diff --git a/nano.spec b/nano.spec
index a2ea50b..8340a5d 100644
--- a/nano.spec
+++ b/nano.spec
@@ -1,7 +1,7 @@
 Summary:         A small text editor
 Name:            nano
 Version:         2.3.1
-Release:         4%{?dist}
+Release:         5%{?dist}
 License:         GPLv3+
 Group:           Applications/Editors
 URL:             http://www.nano-editor.org
@@ -48,7 +48,6 @@ touch -c aclocal.m4 config.h.in configure Makefile.in
 make %{?_smp_mflags}
 
 %install
-rm -rf %{buildroot}
 make DESTDIR="%{buildroot}" install
 #ln -s nano %{buildroot}%{_bindir}/pico
 rm -f %{buildroot}%{_infodir}/dir
@@ -58,8 +57,8 @@ cp %{SOURCE2} ./nanorc
 sed -e 's/# set nowrap/set nowrap/' \
     -e 's/^#.*set speller.*$/set speller "hunspell"/' \
     doc/nanorc.sample >> ./nanorc
-mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}
-install -m 644 ./nanorc $RPM_BUILD_ROOT%{_sysconfdir}/nanorc
+mkdir -p %{buildroot}%{_sysconfdir}
+install -m 644 ./nanorc %{buildroot}%{_sysconfdir}/nanorc
 
 %find_lang %{name}
 
@@ -77,11 +76,7 @@ if [ $1 -eq 0 ]; then
 fi
 exit 0
 
-%clean
-rm -rf %{buildroot}
-
 %files -f %{name}.lang
-%defattr(-,root,root,-)
 %doc AUTHORS BUGS COPYING ChangeLog INSTALL NEWS README THANKS TODO
 %doc doc/nanorc.sample
 %doc doc/faq.html
@@ -93,6 +88,9 @@ rm -rf %{buildroot}
 %{_datadir}/nano
 
 %changelog
+* Tue Aug 28 2012 Kamil Dudka <kdudka at redhat.com> - 2.3.1-5
+- fix specfile issues reported by the fedora-review script
+
 * Fri Jul 20 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 2.3.1-4
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list