[units/f18] fix specfile issues reported by the fedora-review script

Kamil Dudka kdudka at fedoraproject.org
Tue Aug 28 16:14:12 UTC 2012


commit 122b6e0f49d664a84bfd3836d3152ce1b40d58f1
Author: Kamil Dudka <kdudka at redhat.com>
Date:   Tue Aug 28 18:10:43 2012 +0200

    fix specfile issues reported by the fedora-review script

 units.spec |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)
---
diff --git a/units.spec b/units.spec
index 23a5639..e29db99 100644
--- a/units.spec
+++ b/units.spec
@@ -1,12 +1,11 @@
 Summary: A utility for converting amounts from one unit to another
 Name: units
 Version: 2.00
-Release: 2%{?dist}
+Release: 3%{?dist}
 Source: ftp://ftp.gnu.org/gnu/units/%{name}-%{version}.tar.gz
 URL: http://www.gnu.org/software/units/units.html
 License: GPLv3+
 Group: Applications/Engineering
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 Requires(post): /sbin/install-info
 Requires(preun): /sbin/install-info
 BuildRequires: bison
@@ -29,15 +28,10 @@ well as conversions such as Fahrenheit to Celsius.
 make %{?_smp_mflags}
 
 %install
-rm -rf $RPM_BUILD_ROOT
-
 make install DESTDIR=$RPM_BUILD_ROOT 
 
 gzip $RPM_BUILD_ROOT%{_infodir}/units.info
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %post
 if [ -e %{_infodir}/units.info.gz ]; then
   /sbin/install-info %{_infodir}/units.info.gz %{_infodir}/dir || :
@@ -49,7 +43,6 @@ if [ $1 = 0 -a -e %{_infodir}/units.info.gz ]; then
 fi
 
 %files
-%defattr(-,root,root,-)
 %doc ChangeLog COPYING NEWS README
 %{_bindir}/*
 %{_datadir}/units
@@ -57,6 +50,9 @@ fi
 %{_mandir}/man1/*
 
 %changelog
+* Tue Aug 28 2012 Kamil Dudka <kdudka at redhat.com> - 2.00-3
+- fix specfile issues reported by the fedora-review script
+
 * Sun Jul 22 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 2.00-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list