[binutils/f17] Add upstream ld/13621 'dangling global hidden symbol in symtab' patch.
Nicholas Clifton
nickc at fedoraproject.org
Wed Feb 15 12:20:20 UTC 2012
commit 3766669e7008222d33c9ea5d6bf80f61f455ce75
Author: Nick Clifton <nickc at redhat.com>
Date: Wed Feb 15 12:18:29 2012 +0000
Add upstream ld/13621 'dangling global hidden symbol in symtab' patch.
binutils-2.22.52.0.1-ld-13621.patch | 39 +++++++++++++++++++++++++++++++++++
binutils.spec | 20 +++++++++++------
2 files changed, 52 insertions(+), 7 deletions(-)
---
diff --git a/binutils-2.22.52.0.1-ld-13621.patch b/binutils-2.22.52.0.1-ld-13621.patch
new file mode 100644
index 0000000..841162a
--- /dev/null
+++ b/binutils-2.22.52.0.1-ld-13621.patch
@@ -0,0 +1,39 @@
+commit 05906ac72f0f047472989a99dec1e66713157629
+Author: Richard Henderson <rth at redhat.com>
+Date: Mon Feb 13 18:08:50 2012 +0000
+
+ PR ld/13621
+
+ bfd/
+ * linker.c (fix_syms): Force symbols outside any section into
+ bfd_abs_section_ptr.
+ ld/testsuite/
+ * ld-elf/warn2.d: Expect ABS section for Foo.
+
+diff --git a/bfd/linker.c b/bfd/linker.c
+index c51c5df..0404474 100644
+--- a/bfd/linker.c
++++ b/bfd/linker.c
+@@ -3208,6 +3208,12 @@ fix_syms (struct bfd_link_hash_entry *h, void *data)
+ op = op1;
+ }
+
++ /* Refuse to choose a section for which we are out of bounds. */
++ /* ??? This may make most of the above moot. */
++ if (h->u.def.value < op->vma
++ || h->u.def.value > op->vma + op->size)
++ op = bfd_abs_section_ptr;
++
+ h->u.def.value -= op->vma;
+ h->u.def.section = op;
+ }
+index 95b7ef4..a9c05f9 100644
+--- a/ld/testsuite/ld-elf/warn2.d
++++ b/ld/testsuite/ld-elf/warn2.d
+@@ -13,5 +13,5 @@
+ # construct and that the symbol still appears as expected.
+
+ #...
+- +[0-9]+: +[0-9a-f]+ +20 +OBJECT +GLOBAL +DEFAULT +[1-9] Foo
++ +[0-9]+: +[0-9a-f]+ +20 +OBJECT +GLOBAL +DEFAULT +ABS Foo
+ #pass
diff --git a/binutils.spec b/binutils.spec
index 2cfb243..c401669 100644
--- a/binutils.spec
+++ b/binutils.spec
@@ -17,7 +17,7 @@
Summary: A GNU collection of binary utilities
Name: %{?cross}binutils%{?_with_debug:-debug}
Version: 2.22.52.0.1
-Release: 4%{?dist}
+Release: 5%{?dist}
License: GPLv3+
Group: Development/Tools
URL: http://sources.redhat.com/binutils
@@ -37,6 +37,8 @@ Patch07: binutils-2.20.51.0.10-sec-merge-emit.patch
# Upstream http://sourceware.org/git/?p=binutils.git;a=commitdiff;h=f5edd1ac0e79c0356c6a1e2beffcadc0c532be98
# Fixes RH #788107
Patch08: binutils-2.22.52.0.1-weakdef.patch
+# From upstream, fixes ld/13621 bug 'dangling global hidden symbol in symtab'
+Patch09: binutils-2.22.52.0.1-ld-13621.patch
%define gold_arches %ix86 x86_64
@@ -135,6 +137,7 @@ using libelf instead of BFD.
%patch06 -p0 -b .copy-osabi~
%patch07 -p0 -b .sec-merge-emit~
%patch08 -p1 -b .weakdef~
+%patch09 -p1 -b .ld-13621~
# We cannot run autotools as there is an exact requirement of autoconf-2.59.
@@ -429,23 +432,26 @@ exit 0
%endif # %{isnative}
%changelog
+* Wed Feb 14 2012 Mark Wielaard <mjw at redhat.com> - 2.22.52.0.1-5
+- Add upstream ld/13621 'dangling global hidden symbol in symtab' patch.
+
* Wed Feb 08 2012 Adam Williamson <awilliam at redhat.com> - 2.22.52.0.1-4
-- actually apply the patch
+- Actually apply the patch
* Wed Feb 08 2012 Adam Williamson <awilliam at redhat.com> - 2.22.52.0.1-3
-- add upstream weakdef.patch to fix RH #788107
+- Add upstream weakdef.patch to fix RH #788107
-* Wed Feb 01 2012 Nick Clifton <nickc at redhat.com> - 2.22.52.0.1-2
+* Wed Feb 01 2012 Nick Clifton <nickc at redhat.com> - 2.22.52.0.1-2
- Drat - forgot to upload the new tarball. Now done.
-* Wed Feb 01 2012 Nick Clifton <nickc at redhat.com> - 2.22.52.0.1-1
+* Wed Feb 01 2012 Nick Clifton <nickc at redhat.com> - 2.22.52.0.1-1
- Rebase on 2.22.52 release.
- Remove build-id.patch and gold-casts.patch as they are included in the 2.22.52 sources.
-* Fri Jan 13 2012 Nick Clifton <nickc at redhat.com> - 2.22-4
+* Fri Jan 13 2012 Nick Clifton <nickc at redhat.com> - 2.22-4
- Fix bug in GOLD sources parsing signed integers in command line options.
-* Fri Jan 13 2012 Nick Clifton <nickc at redhat.com> - 2.22-3
+* Fri Jan 13 2012 Nick Clifton <nickc at redhat.com> - 2.22-3
- Add casts for building gold with 4.7 version of gcc.
* Thu Jan 12 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 2.22-2
More information about the scm-commits
mailing list