[perl-IO-stringy] Spec clean-up

Paul Howarth pghmcfc at fedoraproject.org
Thu Jan 12 10:25:54 UTC 2012


commit 1b6947e4b12cc4023c355e1cb59ff390fc96c50a
Author: Paul Howarth <paul at city-fan.org>
Date:   Thu Jan 12 10:25:06 2012 +0000

    Spec clean-up
    
    - Nobody else likes macros for commands
    - Use DESTDIR rather than PERL_INSTALL_ROOT
    - Add buildreqs for core perl modules, which may be dual-lived

 perl-IO-stringy.spec |   53 ++++++++++++++++++++++++++++++++-----------------
 1 files changed, 34 insertions(+), 19 deletions(-)
---
diff --git a/perl-IO-stringy.spec b/perl-IO-stringy.spec
index 46fe77e..95fc07f 100644
--- a/perl-IO-stringy.spec
+++ b/perl-IO-stringy.spec
@@ -1,15 +1,24 @@
 Summary:	I/O on in-core objects like strings and arrays for Perl
 Name:		perl-IO-stringy
 Version:	2.110
-Release:	16%{?dist}
+Release:	17%{?dist}
 License:	GPL+ or Artistic
 Group:		Development/Libraries
 URL:		http://search.cpan.org/dist/IO-stringy/
 Source0:	http://search.cpan.org/CPAN/authors/id/D/DS/DSKOLL/IO-stringy-%{version}.tar.gz
 BuildArch:	noarch
-BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+BuildRequires:	perl(Carp)
+BuildRequires:	perl(Exporter)
 BuildRequires:	perl(ExtUtils::MakeMaker)
-Requires:	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+BuildRequires:	perl(FileHandle)
+BuildRequires:	perl(IO::File)
+BuildRequires:	perl(IO::Handle)
+BuildRequires:	perl(IO::Scalar)
+BuildRequires:	perl(IO::ScalarArray)
+BuildRequires:	perl(IO::WrapTie)
+BuildRequires:	perl(Symbol)
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 This toolkit primarily provides modules for performing both traditional
@@ -29,21 +38,21 @@ string, a globref, or a FileHandle.
 %setup -q -n IO-stringy-%{version}
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
-%{__make} %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor
+make %{?_smp_mflags}
 
 %install
-%{__rm} -rf %{buildroot}
-%{__make} pure_install PERL_INSTALL_ROOT=%{buildroot}
-/usr/bin/find %{buildroot} -type f -name .packlist -exec %{__rm} -f {} ';'
-/usr/bin/find %{buildroot} -depth -type d -exec /bin/rmdir {} ';' 2>/dev/null
+rm -rf %{buildroot}
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
+find %{buildroot} -depth -type d -exec rmdir {} ';' 2>/dev/null
 %{_fixperms} %{buildroot}
 
 %check
-%{__make} test
+make test
 
 %clean
-%{__rm} -rf %{buildroot}
+rm -rf %{buildroot}
 
 %files
 %defattr(-,root,root,-)
@@ -59,17 +68,23 @@ string, a globref, or a FileHandle.
 %{_mandir}/man3/IO::WrapTie.3pm*
 
 %changelog
-* Fri Jun 17 2011 Marcela Mašláňová <mmaslano at redhat.com> - 2.110-16
-- Perl mass rebuild
+* Thu Jan 12 2012 Paul Howarth <paul at city-fan.org> 2.110-17
+- spec clean-up:
+  - nobody else likes macros for commands
+  - use DESTDIR rather than PERL_INSTALL_ROOT
+  - add buildreqs for core perl modules, which may be dual-lived
 
-* Tue Feb 08 2011 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 2.110-15
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
+* Fri Jun 17 2011 Marcela Mašláňová <mmaslano at redhat.com> 2.110-16
+- perl mass rebuild
 
-* Mon Dec 20 2010 Marcela Maslanova <mmaslano at redhat.com> - 2.110-14
-- 661697 rebuild for fixing problems with vendorach/lib
+* Tue Feb  8 2011 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> 2.110-15
+- rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
-* Sun May 02 2010 Marcela Maslanova <mmaslano at redhat.com> - 2.110-13
-- Mass rebuild with perl-5.12.0
+* Mon Dec 20 2010 Marcela Maslanova <mmaslano at redhat.com> 2.110-14
+- rebuild to fix problems with vendorarch/lib (#661697)
+
+* Sun May  2 2010 Marcela Maslanova <mmaslano at redhat.com> 2.110-13
+- mass rebuild with perl-5.12.0
 
 * Fri Jan 15 2010 Paul Howarth <paul at city-fan.org> 2.110-12
 - spec cleanups (see also merge review #552564)


More information about the scm-commits mailing list