[perl-common-sense] Spec clean-up

Thu Jan 19 10:13:47 UTC 2012

commit b59fd3739de24ab90543fe591d83bf2a1a71af4c
Author: Paul Howarth <paul at city-fan.org>
Date:   Thu Jan 19 10:13:10 2012 +0000

    Spec clean-up
    
    - Reinstate compatibility with older distributions like EL-5
    - Drop -tests subpackage (general lack of interest in this), but include
      them as documentation for the main package
    - Don't use macros for commands
    - Make %files list more explicit
    - Use tabs

 .gitignore             |    4 +--
 perl-common-sense.spec |   88 ++++++++++++++++++++++++++----------------------
 2 files changed, 49 insertions(+), 43 deletions(-)
---

diff --git a/.gitignore b/.gitignore
index c4af281..1bdcf4a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1 @@
-common-sense-3.0.tar.gz
-/common-sense-3.3.tar.gz
-/common-sense-3.4.tar.gz
+/common-sense-[0-9.]*.tar.gz
diff --git a/perl-common-sense.spec b/perl-common-sense.spec
index 22dc4ab..434d73f 100644
--- a/perl-common-sense.spec
+++ b/perl-common-sense.spec
@@ -1,19 +1,15 @@
-Name:           perl-common-sense
-Summary:        "Common sense" Perl defaults 
-Version:        3.4
-Release:        3%{?dist}
-License:        GPL+ or Artistic
-Group:          Development/Libraries
-Source0:        http://search.cpan.org/CPAN/authors/id/M/ML/MLEHMANN/common-sense-%{version}.tar.gz 
-URL:            http://search.cpan.org/dist/common-sense
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
-BuildArch:      noarch
-
-BuildRequires:  perl(ExtUtils::MakeMaker)
-
-
-%{?perl_default_filter}
-%{?perl_default_subpackage_tests}
+Name:		perl-common-sense
+Summary:	"Common sense" Perl defaults 
+Version:	3.4
+Release:	4%{?dist}
+License:	GPL+ or Artistic
+Group:		Development/Libraries
+Source0:	http://search.cpan.org/CPAN/authors/id/M/ML/MLEHMANN/common-sense-%{version}.tar.gz 
+URL:		http://search.cpan.org/dist/common-sense
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+BuildArch:	noarch
+BuildRequires:	perl(ExtUtils::MakeMaker)
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 This module implements some sane defaults for Perl programs, as defined
@@ -28,61 +24,73 @@ Perl coders:
 %setup -q -n common-sense-%{version}
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
+rm -rf %{buildroot}
 make pure_install DESTDIR=%{buildroot}
-find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
-
-%{_fixperms} %{buildroot}/*
+find %{buildroot} -type f -name .packlist -exec rm -f {} \;
+find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
+%{_fixperms} %{buildroot}
 
 %check
 make test
 
+%clean
+rm -rf %{buildroot}
+
 %files
-%doc LICENSE Changes README
-%{perl_vendorlib}/*
-%{_mandir}/man3/*.3*
+%defattr(-,root,root,-)
+%doc LICENSE Changes README t/
+%{perl_vendorlib}/common/
+%{_mandir}/man3/common::sense.3pm*
 
 %changelog
+* Thu Jan 19 2012 Paul Howarth <paul at city-fan.org> - 3.4-4
+- Reinstate compatibility with older distributions like EL-5
+- Drop -tests subpackage (general lack of interest in this), but include
+  them as documentation for the main package
+- Don't use macros for commands
+- Make %%files list more explicit
+- Use tabs
+
 * Sat Jan 14 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 3.4-3
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
 
 * Fri Jun 17 2011 Marcela Mašláňová <mmaslano at redhat.com> - 3.4-2
 - Perl mass rebuild
 
-* Sat May 07 2011 Iain Arnell <iarnell at gmail.com> 3.4-1
-- update to latest upstream version
+* Sat May 07 2011 Iain Arnell <iarnell at gmail.com> - 3.4-1
+- Update to latest upstream version
 
 * Wed Feb 09 2011 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 3.3-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
 * Sat Dec 18 2010 Iain Arnell <iarnell at gmail.com> 3.3-1
-- update to latest upstream version
-- clean up spec for modern rpmbuild
+- Update to latest upstream version
+- Clean up spec for modern rpmbuild
 
 * Wed Dec 15 2010 Marcela Maslanova <mmaslano at redhat.com> - 3.0-3
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
 
 * Fri Apr 30 2010 Marcela Maslanova <mmaslano at redhat.com> - 3.0-2
 - Mass rebuild with perl-5.12.0
 
-* Sun Mar 14 2010 Chris Weyl <cweyl at alumni.drew.edu> 3.0-1
-- update by Fedora::App::MaintainerTools 0.006
+* Sun Mar 14 2010 Chris Weyl <cweyl at alumni.drew.edu> - 3.0-1
+- Update by Fedora::App::MaintainerTools 0.006
 - PERL_INSTALL_ROOT => DESTDIR
-- updating to latest GA CPAN version (3.0)
+- Updating to latest GA CPAN version (3.0)
 
 * Fri Dec  4 2009 Stepan Kasal <skasal at redhat.com> - 1.0-3
-- rebuild against perl 5.10.1
+- Rebuild against perl 5.10.1
 
-* Sun Sep 27 2009 Chris Weyl <cweyl at alumni.drew.edu> 1.0-2
-- update summary (though now we deviate from upstream)
+* Sun Sep 27 2009 Chris Weyl <cweyl at alumni.drew.edu> - 1.0-2
+- Update summary (though now we deviate from upstream)
 
-* Mon Aug 31 2009 Chris Weyl <cweyl at alumni.drew.edu> 1.0-1
-- auto-update to 1.0 (by cpan-spec-update 0.01)
+* Mon Aug 31 2009 Chris Weyl <cweyl at alumni.drew.edu> - 1.0-1
+- Auto-update to 1.0 (by cpan-spec-update 0.01)
 
-* Fri Aug 21 2009 Chris Weyl <cweyl at alumni.drew.edu> 0.04-0
-- initial RPM packaging
-- generated with cpan2dist (CPANPLUS::Dist::RPM version 0.0.8)
+* Fri Aug 21 2009 Chris Weyl <cweyl at alumni.drew.edu> - 0.04-0
+- Initial RPM packaging
+- Generated with cpan2dist (CPANPLUS::Dist::RPM version 0.0.8)
