[perl-Hash-Util-FieldHash-Compat] Spec clean-up

Paul Howarth pghmcfc at fedoraproject.org
Mon Jan 23 15:42:34 UTC 2012


commit 9292af09c3c80f02339e6a5175a947ffaa499c72
Author: Paul Howarth <paul at city-fan.org>
Date:   Mon Jan 23 15:41:53 2012 +0000

    Spec clean-up
    
    - BR: perl(Scalar::Util), perl(Tie::RefHash) and perl(Tie::RefHash::Weak)
    - Make %files list more explicit
    - Use DESTDIR rather than PERL_INSTALL_ROOT
    - Don't use macros for commands
    - Use search.cpan.org source URL

 .gitignore                           |    2 +-
 perl-Hash-Util-FieldHash-Compat.spec |   72 +++++++++++++++++++---------------
 2 files changed, 41 insertions(+), 33 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index d7cf8c6..4a1fb5c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1 @@
-Hash-Util-FieldHash-Compat-0.03.tar.gz
+/Hash-Util-FieldHash-Compat-[0-9.]*.tar.gz
diff --git a/perl-Hash-Util-FieldHash-Compat.spec b/perl-Hash-Util-FieldHash-Compat.spec
index dd63570..cf926a4 100644
--- a/perl-Hash-Util-FieldHash-Compat.spec
+++ b/perl-Hash-Util-FieldHash-Compat.spec
@@ -1,24 +1,27 @@
-Name:           perl-Hash-Util-FieldHash-Compat
-Version:        0.03
-Release:        10%{?dist}
-Summary:        Use Hash::Util::FieldHash or ties, depending on availability
-License:        GPL+ or Artistic
-Group:          Development/Libraries
-URL:            http://search.cpan.org/dist/Hash-Util-FieldHash-Compat/
-Source0:        http://www.cpan.org/authors/id/N/NU/NUFFIN/Hash-Util-FieldHash-Compat-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-BuildArch:      noarch
-BuildRequires:  perl(ExtUtils::MakeMaker)
-BuildRequires:  perl(Test::use::ok)
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Name:		perl-Hash-Util-FieldHash-Compat
+Version:	0.03
+Release:	11%{?dist}
+Summary:	Use Hash::Util::FieldHash or ties, depending on availability
+License:	GPL+ or Artistic
+Group:		Development/Libraries
+URL:		http://search.cpan.org/dist/Hash-Util-FieldHash-Compat/
+Source0:	http://search.cpan.org/CPAN/authors/id/N/NU/NUFFIN/Hash-Util-FieldHash-Compat-%{version}.tar.gz
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+BuildArch:	noarch
+BuildRequires:	perl(ExtUtils::MakeMaker)
+BuildRequires:	perl(Scalar::Util)
+BuildRequires:	perl(Test::use::ok)
+BuildRequires:	perl(Tie::RefHash)
+BuildRequires:	perl(Tie::RefHash::Weak)
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 # Filter unversioned provide, leaving just the versioned one (rpm 4.9 onwards)
 %global __provides_exclude ^perl\\(Hash::Util::FieldHash::Compat\\)$
 
 %description
-Under older perls this module provides a drop in compatible api to
+Under older perls this module provides a drop in compatible API to
 Hash::Util::FieldHash using perltie. When Hash::Util::FieldHash is
-available it will use that instead.
+available, it will use that instead.
 
 %prep
 %setup -q -n Hash-Util-FieldHash-Compat-%{version}
@@ -28,32 +31,37 @@ available it will use that instead.
 %define __perl_provides %{provfilt}
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
-rm -rf $RPM_BUILD_ROOT
-
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} $RPM_BUILD_ROOT/*
+rm -rf %{buildroot}
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -exec rm -f {} \;
+find %{buildroot} -depth -type d -exec rmdir {} \; 2>/dev/null
+%{_fixperms} %{buildroot}
 
 %check
 make test
 
 %clean
-rm -rf $RPM_BUILD_ROOT
+rm -rf %{buildroot}
 
 %files
 %defattr(-,root,root,-)
-%doc 
-%{perl_vendorlib}/*
-%{_mandir}/man3/*
+%{perl_vendorlib}/Hash/
+%{_mandir}/man3/Hash::Util::FieldHash::Compat.3pm*
+%{_mandir}/man3/Hash::Util::FieldHash::Compat::Heavy.3pm*
 
 %changelog
+* Mon Jan 23 2012 Paul Howarth <paul at city-fan.org> - 0.03-11
+- Spec clean-up
+  - BR: perl(Scalar::Util), perl(Tie::RefHash) and perl(Tie::RefHash::Weak)
+  - Make %%files list more explicit
+  - Use DESTDIR rather than PERL_INSTALL_ROOT
+  - Don't use macros for commands
+  - Use search.cpan.org source URL
+
 * Fri Jan 13 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.03-10
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
 
@@ -68,13 +76,13 @@ rm -rf $RPM_BUILD_ROOT
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
 * Fri Dec 17 2010 Marcela Maslanova <mmaslano at redhat.com> - 0.03-6
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
 
 * Sun May 02 2010 Marcela Maslanova <mmaslano at redhat.com> - 0.03-5
 - Mass rebuild with perl-5.12.0
 
 * Mon Dec  7 2009 Stepan Kasal <skasal at redhat.com> - 0.03-4
-- rebuild against perl 5.10.1
+- Rebuild against perl 5.10.1
 
 * Sat Jul 25 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.03-3
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
@@ -82,5 +90,5 @@ rm -rf $RPM_BUILD_ROOT
 * Thu Feb 26 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.03-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
 
-* Thu Jan 29 2009 Allisson Azevedo <allisson at gmail.com> 0.03-1
-- Initial rpm release.
+* Thu Jan 29 2009 Allisson Azevedo <allisson at gmail.com> - 0.03-1
+- Initial rpm release


More information about the scm-commits mailing list