[perl-URI-Title] Fixing reviewer's TODOs
Petr Šabata
psabata at fedoraproject.org
Tue Jan 24 11:59:33 UTC 2012
commit 89ef79a677845af50b6f02769c14d15680688bef
Author: Petr Šabata <contyk at redhat.com>
Date: Tue Jan 24 12:56:10 2012 +0100
Fixing reviewer's TODOs
perl-URI-Title.spec | 23 ++++++++++-------------
1 files changed, 10 insertions(+), 13 deletions(-)
---
diff --git a/perl-URI-Title.spec b/perl-URI-Title.spec
index 7e8e637..e7e9fea 100644
--- a/perl-URI-Title.spec
+++ b/perl-URI-Title.spec
@@ -9,6 +9,7 @@ URL: http://search.cpan.org/dist/URI-Title/
Source0: http://www.cpan.org/authors/id/T/TO/TOMI/URI-Title-%{version}.tar.gz
BuildArch: noarch
BuildRequires: perl(base)
+BuildRequires: perl(lib)
BuildRequires: perl(Carp)
BuildRequires: perl(Exporter)
BuildRequires: perl(ExtUtils::MakeMaker)
@@ -30,19 +31,15 @@ Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $versi
%global __requires_exclude %__requires_exclude|^perl\\(Module::Pluggable\\)
%description
-I keep having to find the title of things on the web. This
-seems like a really simple request, just get() the object,
-parse for a title tag, you're done. Ha, I wish. There are
-several problems with this approach:
+I keep having to find the title of things on the web. This seems like a really
+simple request, just get() the object, parse for a title tag, you're done.
+Ha, I wish. There are several problems with this approach:
-What if the resource is on a very slow server? Do we wait
-forever or what?
-What if the resource is a 900 gig file? You don't want to
-download that.
-What if the page title isn't in a title tag, but is buried
-in the HTML somewhere?
-What if the resource is an MP3 file, or a word document
-or something?
+What if the resource is on a very slow server? Do we wait forever or what?
+What if the resource is a 900 gig file? You don't want to download that.
+What if the page title isn't in a title tag, but is buried in the HTML
+somewhere?
+What if the resource is an MP3 file, or a word document or something?
...
So, let's solve these issues once.
@@ -64,7 +61,7 @@ find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
make test
%files
-%doc Changes
+%doc Changes title.pl
%{perl_vendorlib}/*
%{_mandir}/man3/*
More information about the scm-commits
mailing list