[kernel/f17] Patch from Stanislaw Gruszka to fix rt2x00 USB access point (rhbz 828824)

Josh Boyer jwboyer at fedoraproject.org
Wed Jul 4 15:35:07 UTC 2012


commit 470b70635f77573ab040b0c77f13442ea8ac3efb
Author: Josh Boyer <jwboyer at redhat.com>
Date:   Wed Jul 4 11:30:05 2012 -0400

    Patch from Stanislaw Gruszka to fix rt2x00 USB access point (rhbz 828824)

 kernel.spec                                        |    9 ++++
 ...usb-fix-indexes-ordering-on-RX-queue-kick.patch |   43 ++++++++++++++++++++
 2 files changed, 52 insertions(+), 0 deletions(-)
---
diff --git a/kernel.spec b/kernel.spec
index e6f767f..b2f79eb 100644
--- a/kernel.spec
+++ b/kernel.spec
@@ -804,6 +804,9 @@ Patch22041: ath9k-fix-panic-caused-by-returning-a-descriptor-we-.patch
 #rhbz 834910
 Patch22042: ACPI-video-Still-use-ACPI-backlight-control-if-_DOS-doesnt-exist.patch
 
+#rhbz 828824
+Patch22043: rt2x00usb-fix-indexes-ordering-on-RX-queue-kick.patch
+
 # END OF PATCH DEFINITIONS
 
 %endif
@@ -1546,6 +1549,9 @@ ApplyPatch ath9k-fix-panic-caused-by-returning-a-descriptor-we-.patch
 #rhbz 834910
 ApplyPatch ACPI-video-Still-use-ACPI-backlight-control-if-_DOS-doesnt-exist.patch
 
+#rhbz 828824
+ApplyPatch rt2x00usb-fix-indexes-ordering-on-RX-queue-kick.patch
+
 # END OF PATCH APPLICATIONS
 
 %endif
@@ -2406,6 +2412,9 @@ fi
 #    '-'      |  |
 #              '-'
 %changelog
+* Wed Jul 4 2012 Josh Boyer <jwboyer at redhat.com>
+- Patch from Stanislaw Gruszka to fix rt2x00 USB access point (rhbz 828824)
+
 * Tue Jul 3 2012 Josh Boyer <jwboyer at redhat.com>
 - Allow ACPI backlight to still work if _DOS isn't present (rhbz 834910)
 
diff --git a/rt2x00usb-fix-indexes-ordering-on-RX-queue-kick.patch b/rt2x00usb-fix-indexes-ordering-on-RX-queue-kick.patch
new file mode 100644
index 0000000..76b83cc
--- /dev/null
+++ b/rt2x00usb-fix-indexes-ordering-on-RX-queue-kick.patch
@@ -0,0 +1,43 @@
+From e899a84a6e9bec0ce653713a48ca121cd754430c Mon Sep 17 00:00:00 2001
+From: Stanislaw Gruszka <sgruszka at redhat.com>
+Date: Mon, 2 Jul 2012 09:42:14 +0200
+Subject: [PATCH] rt2x00usb: fix indexes ordering on RX queue kick
+
+On rt2x00_dmastart() we increase index specified by Q_INDEX and on
+rt2x00_dmadone() we increase index specified by Q_INDEX_DONE. So entries
+between Q_INDEX_DONE and Q_INDEX are those we currently process in the
+hardware. Entries between Q_INDEX and Q_INDEX_DONE are those we can
+submit to the hardware.
+
+According to that fix rt2x00usb_kick_queue(), as we need to submit rx
+entries that are not processed by the hardware. It worked before only
+for empty queue, otherwise was broken.
+
+Note that for TX queues indexes ordering are ok. We need to kick entries
+that have filled skb, but was not submitted to the hardware, i.e.
+strted from Q_INDEX_DONE and have ENTRY_DATA_PENDING bit set.
+
+From practical standpoint this patch fixes AP mode connection hangs.
+
+Signed-off-by: Stanislaw Gruszka <sgruszka at redhat.com>
+---
+ drivers/net/wireless/rt2x00/rt2x00usb.c |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.c b/drivers/net/wireless/rt2x00/rt2x00usb.c
+index d357d1e..74ecc33 100644
+--- a/drivers/net/wireless/rt2x00/rt2x00usb.c
++++ b/drivers/net/wireless/rt2x00/rt2x00usb.c
+@@ -436,8 +436,8 @@ void rt2x00usb_kick_queue(struct data_queue *queue)
+ 	case QID_RX:
+ 		if (!rt2x00queue_full(queue))
+ 			rt2x00queue_for_each_entry(queue,
+-						   Q_INDEX_DONE,
+ 						   Q_INDEX,
++						   Q_INDEX_DONE,
+ 						   NULL,
+ 						   rt2x00usb_kick_rx_entry);
+ 		break;
+-- 
+1.7.1
+


More information about the scm-commits mailing list