[nettle] More review feedback: remove explicit buildroot handling and defattr
David Woodhouse
dwmw2 at fedoraproject.org
Thu Jul 5 12:47:30 UTC 2012
commit ff71355c7b8544cdd672e2d18445c7c7783df038
Author: David Woodhouse <David.Woodhouse at intel.com>
Date: Thu Jul 5 13:11:44 2012 +0100
More review feedback: remove explicit buildroot handling and defattr
nettle.spec | 13 ++++---------
1 files changed, 4 insertions(+), 9 deletions(-)
---
diff --git a/nettle.spec b/nettle.spec
index 3725e91..f72bae2 100644
--- a/nettle.spec
+++ b/nettle.spec
@@ -1,13 +1,12 @@
Name: nettle
Version: 2.4
-Release: 2%{?dist}
+Release: 3%{?dist}
Summary: A low-level cryptographic library
Group: Development/Libraries
License: LGPLv2+
URL: http://www.lysator.liu.se/~nisse/nettle/
Source0: http://www.lysator.liu.se/~nisse/archive/%{name}-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRequires: gmp-devel m4 texinfo-tex texlive-dvips ghostscript
@@ -52,7 +51,6 @@ make %{?_smp_mflags}
%install
-rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
make install-shared DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
mkdir -p $RPM_BUILD_ROOT%{_infodir}
@@ -64,12 +62,7 @@ chmod 0755 $RPM_BUILD_ROOT%{_libdir}/libhogweed.so.2.1
%check
make check
-%clean
-rm -rf $RPM_BUILD_ROOT
-
-
%files
-%defattr(-,root,root,-)
%doc AUTHORS ChangeLog COPYING.LIB NEWS README TODO
%{_infodir}/nettle.info.gz
%{_bindir}/nettle-lfib-stream
@@ -83,7 +76,6 @@ rm -rf $RPM_BUILD_ROOT
%files devel
-%defattr(-,root,root,-)
%doc descore.README nettle.html nettle.pdf COPYING.LIB
%{_includedir}/nettle
%{_libdir}/libnettle.so
@@ -105,6 +97,9 @@ fi
%changelog
+* Thu Jul 05 2012 David Woodhouse <dwmw2 at infradead.org> - 2.4-3
+- Remove explicit buildroot handling and defattr.
+
* Wed Jul 04 2012 David Woodhouse <dwmw2 at infradead.org> - 2.4-2
- Review feedback
More information about the scm-commits
mailing list